Re: [PATCH 11/13] PCI: Add has_mem64 for struct host_bridge

From	Christian König <deathsimple@vodafone.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 11/13] PCI: Add has_mem64 for struct host_bridge
Date	2017-05-08 11:00 +0200
Message-ID	<tEMGm-1Cq-3@gated-at.bofh.it> (permalink)
References	<tyyZr-1MT-3@gated-at.bofh.it> <tyyZr-1MT-5@gated-at.bofh.it> <tDy2J-1GI-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am 05.05.2017 um 01:04 schrieb Bjorn Helgaas:
> [+cc Christian]
Thanks for that.

> [SNIP]
> I *think* this will be broken by the current implementation of
> Christian's patch to enable a 64-bit host bridge window:
>
>    https://lkml.kernel.org/r/1493890270-1188-5-git-send-email-deathsimple@vodafone.de
>
> because pci_register_host_bridge() runs before we scan the bus, and
> Christian's patch adds a quirk that runs when we enumerate the AMD
> host bridge device.
>
> If we apply this and Christian's patch, I think we could end up with
> a host bridge window above 4G, but with bridge->has_mem64 not set.
Yes, indeed. I can adjust my patch, but I would prefer not to do so.

I don't completely understand the background of this change, but from 
what I know how the BIOS (at least on X86) allocates resources it 
doesn't sounds correct to me.

Maybe we just need a Sparc specific quirk here instead of changing the 
common logic?

Regards,
Christian.

Thread

Re: [PATCH 11/13] PCI: Add has_mem64 for struct host_bridge Bjorn Helgaas <helgaas@kernel.org> - 2017-05-05 01:10 +0200
  Re: [PATCH 11/13] PCI: Add has_mem64 for struct host_bridge Christian König <deathsimple@vodafone.de> - 2017-05-08 11:00 +0200
    Re: [PATCH 11/13] PCI: Add has_mem64 for struct host_bridge Bjorn Helgaas <helgaas@kernel.org> - 2017-05-08 15:30 +0200
      Re: [PATCH 11/13] PCI: Add has_mem64 for struct host_bridge Christian König <deathsimple@vodafone.de> - 2017-05-09 13:50 +0200

csiph-web