[PATCH 1/4] crypto: handle EBUSY due to backlog correctly

From	Gilad Ben-Yossef <gilad@benyossef.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/4] crypto: handle EBUSY due to backlog correctly
Date	2017-05-11 14:00 +0200
Message-ID	<tFUVc-5Qu-23@gated-at.bofh.it> (permalink)
References	<tFUVb-5Qu-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

public_key_verify_signature() was passing the CRYPTO_TFM_REQ_MAY_BACKLOG
flag to akcipher_request_set_callback() but was not handling correctly
the case where a -EBUSY error could be returned from the call to
crypto_akcipher_verify() if backlog was used, possibly casuing
data corruption due to use-after-free of buffers.

Resolve this by handling -EBUSY correctly.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
CC: stable@vger.kernel.org
---
 crypto/asymmetric_keys/public_key.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/asymmetric_keys/public_key.c b/crypto/asymmetric_keys/public_key.c
index d3a989e..3cd6e12 100644
--- a/crypto/asymmetric_keys/public_key.c
+++ b/crypto/asymmetric_keys/public_key.c
@@ -141,7 +141,7 @@ int public_key_verify_signature(const struct public_key *pkey,
 	 * signature and returns that to us.
 	 */
 	ret = crypto_akcipher_verify(req);
-	if (ret == -EINPROGRESS) {
+	if ((ret == -EINPROGRESS) || (ret == -EBUSY)) {
 		wait_for_completion(&compl.completion);
 		ret = compl.err;
 	}
-- 
2.1.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] crypto: async crypto op fixes Gilad Ben-Yossef <gilad@benyossef.com> - 2017-05-11 14:00 +0200
  [PATCH 2/4] crypto: drbg wait for crypto op not signal safe Gilad Ben-Yossef <gilad@benyossef.com> - 2017-05-11 14:00 +0200
  [PATCH 1/4] crypto: handle EBUSY due to backlog correctly Gilad Ben-Yossef <gilad@benyossef.com> - 2017-05-11 14:00 +0200

csiph-web