Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1639338

[PATCH 2/2] alpha-module: Delete an error message for a failed memory allocation in module_frob_arch_sections()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 11 May 2017 13:00:34 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/alpha/kernel/module.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/alpha/kernel/module.c b/arch/alpha/kernel/module.c
index 387d9c500e48..211e62e9a0af 100644
--- a/arch/alpha/kernel/module.c
+++ b/arch/alpha/kernel/module.c
@@ -109,9 +109,5 @@ module_frob_arch_sections(Elf64_Ehdr *hdr, Elf64_Shdr *sechdrs,
-	if (!chains) {
-		printk(KERN_ERR
-		       "module %s: no memory for symbol chain buffer\n",
-		       me->name);
+	if (!chains)
 		return -ENOMEM;
-	}
 
 	got->sh_size = 0;
 	got->sh_addralign = 8;
-- 
2.12.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] alpha-module: Adjustments for module_frob_arch_sections() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-11 14:00 +0200
  [PATCH 2/2] alpha-module: Delete an error message for a failed memory  allocation in module_frob_arch_sections() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-11 14:00 +0200
  [PATCH 1/2] alpha-module: Improve a size determination in  module_frob_arch_sections() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-11 14:00 +0200

csiph-web