Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1638970

[PATCHv2] drm/prime: Forward declare struct device

From Laura Abbott <labbott@redhat.com>
Newsgroups linux.kernel
Subject [PATCHv2] drm/prime: Forward declare struct device
Date 2017-05-10 19:10 +0200
Message-ID <tFDhD-3pT-17@gated-at.bofh.it> (permalink)
References <tFB69-1Xf-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


We need a declaration of struct device to avoid warnings:

In file included from include/drm/drm_file.h:38:0,
                 from drivers/gpu/drm/drm_file.c:38:
include/drm/drm_prime.h:71:14: warning: 'struct device' declared inside
	  parameter list will not be visible outside of this definition or
	  declaration
          struct device *attach_dev);
		 ^~~~~~

Forward declare it.

Signed-off-by: Laura Abbott <labbott@redhat.com>
---
v2: Switch to foward declaration instead of including a header.
---
 include/drm/drm_prime.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/drm/drm_prime.h b/include/drm/drm_prime.h
index 46fd1fb..59ccab4 100644
--- a/include/drm/drm_prime.h
+++ b/include/drm/drm_prime.h
@@ -50,6 +50,8 @@ struct drm_prime_file_private {
 	struct rb_root handles;
 };
 
+struct device;
+
 struct dma_buf_export_info;
 struct dma_buf;
 
-- 
2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] drm/prime: include device.h Laura Abbott <labbott@redhat.com> - 2017-05-10 16:50 +0200
  Re: [PATCH] drm/prime: include device.h Chris Wilson <chris@chris-wilson.co.uk> - 2017-05-10 16:50 +0200
    [PATCHv2] drm/prime: Forward declare struct device Laura Abbott <labbott@redhat.com> - 2017-05-10 19:10 +0200
      Re: [PATCHv2] drm/prime: Forward declare struct device Sumit Semwal <sumit.semwal@linaro.org> - 2017-05-10 19:20 +0200

csiph-web