Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1638892
| From | Chris Wilson <chris@chris-wilson.co.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drm/prime: include device.h |
| Date | 2017-05-10 16:50 +0200 |
| Message-ID | <tFB69-1Xf-21@gated-at.bofh.it> (permalink) |
| References | <tFB69-1Xf-19@gated-at.bofh.it> <tFB69-1Xf-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, May 10, 2017 at 07:40:01AM -0700, Laura Abbott wrote: > Explictly add linux/device.h to ensure struct device is defined: > > In file included from include/drm/drm_file.h:38:0, > from drivers/gpu/drm/drm_file.c:38: > include/drm/drm_prime.h:71:14: warning: 'struct device' declared inside > parameter list will not be visible outside of this definition or > declaration > struct device *attach_dev); We aren't using it for anything other than an opaque pointer, so a struct device; forward decl will suffice? -Chris -- Chris Wilson, Intel Open Source Technology Centre
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drm/prime: include device.h Laura Abbott <labbott@redhat.com> - 2017-05-10 16:50 +0200
Re: [PATCH] drm/prime: include device.h Chris Wilson <chris@chris-wilson.co.uk> - 2017-05-10 16:50 +0200
[PATCHv2] drm/prime: Forward declare struct device Laura Abbott <labbott@redhat.com> - 2017-05-10 19:10 +0200
Re: [PATCHv2] drm/prime: Forward declare struct device Sumit Semwal <sumit.semwal@linaro.org> - 2017-05-10 19:20 +0200
csiph-web