Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637755

Re: [PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error path

From Florian Fainelli <f.fainelli@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error path
Date 2017-05-09 00:00 +0200
Message-ID <tEYRc-ZP-9@gated-at.bofh.it> (permalink)
References <tEYHv-Wn-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 05/08/2017 02:48 PM, Jon Mason wrote:
> If an error is encountered in mdio_mux_init(), the error path will call
> mdiobus_free().  Since mdiobus_register() has been called prior to
> mdio_mux_init(), the bus->state will not be MDIOBUS_UNREGISTERED.  This
> causes a BUG_ON() in mdiobus_free().  To correct this issue, add an
> error path for mdio_mux_init() which calls mdiobus_unregister() prior to
> mdiobus_free().
> 
> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
> Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs")

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error path Jon Mason <jon.mason@broadcom.com> - 2017-05-08 23:50 +0200
  Re: [PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error  path Florian Fainelli <f.fainelli@gmail.com> - 2017-05-09 00:00 +0200
  Re: [PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error  path David Miller <davem@davemloft.net> - 2017-05-09 00:10 +0200

csiph-web