Re: [PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error path

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error path
Date	Tue, 09 May 2017 00:00:02 +0200
Message-ID	<tEYRc-ZP-9@gated-at.bofh.it> (permalink)
References	<tEYHv-Wn-3@gated-at.bofh.it>
X-Original-To	Jon Mason <jon.mason@broadcom.com>, Florian Fainelli <f.fainelli@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=jMrSjSnQL4OlND6zxzjUB/x1srfgvGxQX+Ce6h1nEX0=; b=ipZ6zJa/ACgCMaP4ijNCKpUmb8AwoN0xnbCObk+Bv4nkY5CzEwkFkQwwGNG9ucO51p +96KuVPMVFLRsmjCzq3EoAau7lhiWr5d4Ptb4KyRrcpuChQlcY8WLYquRHB6HSdzYYcg PvaIstDD1mBinPDgVnTYtnlOLY4pqrZ46qfYENDSUuwzRJGjywS2qZpYiCKcR8DEBbaH ht0ErR4cJvea/8m7hS+HfjJ0q3L90/VTpG0z9G3g+YCTQcB0ij7jkpmt8na840FjMPNF RiXREBN7xWkpwjucN+UH59hn+IAeccIWslskmPb0mj9jNe0omcgEbrkDRnUElU+yLgKk AKPA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=jMrSjSnQL4OlND6zxzjUB/x1srfgvGxQX+Ce6h1nEX0=; b=HkypRgKXpyzUfRe3eHHqu0AOMBurALWm2waGwAgoMy9+NQMpxwAktsSjXKTyBIwTVt 1RfNX2+INRo2/1UcTkZnUYV3NzRGsHz+o4GUrAgD7QhJ9TQFdzfeTtTkKk54o32x2ZR6 vaB4LSKVzzMmJqqGWOO9UlAHtIrO2JjyglNiter+ZdyMdA53ezXsARlcM+oHLsXCTEIk q3l10CRQ1aBhDU7o4o+JiXqZ9VgqrpKTQf4Gy14UmKi3hVVzLx1t8Rm273lhtj6Ymmux zUWMrpGlHsGHacVp4qPP8lVJ7XJ2ODu38AighBB5DJdqXZX3MUQGJnHrKG3nETboy7T1 ecPw==
X-Gm-Message-State	AODbwcCti+q5Dv5KpP0Pg/4NouuB3NeUBBlr6WECIScAofDcujsu+M4c +AoaZfyP8DYafQ==
X-Received	by 10.28.109.29 with SMTP id i29mr4937422wmc.113.1494280423493; Mon, 08 May 2017 14:53:43 -0700 (PDT)
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	14
Organization	linux.* mail to news gateway
X-Original-Cc	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com
X-Original-Date	Mon, 8 May 2017 14:53:38 -0700
X-Original-Message-ID	<43692ac5-6db4-2ab1-737c-424be7db20f7@gmail.com>
X-Original-References	<1494280115-9252-1-git-send-email-jon.mason@broadcom.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1637755

Show key headers only | View raw

On 05/08/2017 02:48 PM, Jon Mason wrote:
> If an error is encountered in mdio_mux_init(), the error path will call
> mdiobus_free().  Since mdiobus_register() has been called prior to
> mdio_mux_init(), the bus->state will not be MDIOBUS_UNREGISTERED.  This
> causes a BUG_ON() in mdiobus_free().  To correct this issue, add an
> error path for mdio_mux_init() which calls mdiobus_unregister() prior to
> mdiobus_free().
> 
> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
> Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs")

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Thread

[PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error path Jon Mason <jon.mason@broadcom.com> - 2017-05-08 23:50 +0200
  Re: [PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error  path Florian Fainelli <f.fainelli@gmail.com> - 2017-05-09 00:00 +0200
  Re: [PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error  path David Miller <davem@davemloft.net> - 2017-05-09 00:10 +0200

csiph-web