Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637649

Re: [PATCH] drm/vc4: Enable selection in Kconfig on any BCM platform.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Florian Fainelli <f.fainelli@gmail.com> writes:

> On 05/08/2017 11:18 AM, Eric Anholt wrote:
>> With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS"
>> to let the module get built on a cygnus-only kernel.  However, I
>> anticipate having a port for Kona soon, so just present the module on
>> all of BCM.
>
> This seems reasonable, but by replacing ARCH_BCM2835 which is common to
> ARM/Linux and ARM64/Linux, you are no longer allowing an ARM64 systems
> to benefit from this driver unless COMPILE_TEST is also selected, right?
>
> This could be:
>
> depends on COMPILE_TEST
> depends on ARCH_BCM # 32-bit ARM
> depends on ARCH_BCM2835 || ARCH_BCM_IPROC # 64-bit ARM
>
> or maybe down to just:
>
> depends on COMPILE_TEST
>
> and let DRM, COMMON_CLK and SND drive the bulk of the dependencies?

That would disable it on ARCH_BCM2835 && !COMPILE_TEST, right?
COMPILE_TEST is typically disabled.

I think I should use ARCH_BCM2835 || ARCH_BCM || COMPILE_TEST.  Does
that sound good?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/vc4: Enable selection in Kconfig on any BCM platform. Eric Anholt <eric@anholt.net> - 2017-05-08 20:20 +0200
  Re: [PATCH] drm/vc4: Enable selection in Kconfig on any BCM platform. Florian Fainelli <f.fainelli@gmail.com> - 2017-05-08 20:40 +0200
    Re: [PATCH] drm/vc4: Enable selection in Kconfig on any BCM platform. Scott Branden <scott.branden@broadcom.com> - 2017-05-08 20:40 +0200
    Re: [PATCH] drm/vc4: Enable selection in Kconfig on any BCM platform. Eric Anholt <eric@anholt.net> - 2017-05-08 21:10 +0200

csiph-web