Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1637634
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drm/vc4: Enable selection in Kconfig on any BCM platform. |
| Date | 2017-05-08 20:40 +0200 |
| Message-ID | <tEVJD-7xa-5@gated-at.bofh.it> (permalink) |
| References | <tEVqi-7nq-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 05/08/2017 11:18 AM, Eric Anholt wrote: > With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" > to let the module get built on a cygnus-only kernel. However, I > anticipate having a port for Kona soon, so just present the module on > all of BCM. This seems reasonable, but by replacing ARCH_BCM2835 which is common to ARM/Linux and ARM64/Linux, you are no longer allowing an ARM64 systems to benefit from this driver unless COMPILE_TEST is also selected, right? This could be: depends on COMPILE_TEST depends on ARCH_BCM # 32-bit ARM depends on ARCH_BCM2835 || ARCH_BCM_IPROC # 64-bit ARM or maybe down to just: depends on COMPILE_TEST and let DRM, COMMON_CLK and SND drive the bulk of the dependencies? > > Signed-off-by: Eric Anholt <eric@anholt.net> > --- > > I would be sending this through drm-misc-next, assuming BCM > maintainers like it. > > drivers/gpu/drm/vc4/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig > index 973b4203c0b2..f136813abf56 100644 > --- a/drivers/gpu/drm/vc4/Kconfig > +++ b/drivers/gpu/drm/vc4/Kconfig > @@ -1,6 +1,6 @@ > config DRM_VC4 > tristate "Broadcom VC4 Graphics" > - depends on ARCH_BCM2835 || COMPILE_TEST > + depends on ARCH_BCM || COMPILE_TEST > depends on DRM > depends on SND && SND_SOC > depends on COMMON_CLK > -- Florian
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drm/vc4: Enable selection in Kconfig on any BCM platform. Eric Anholt <eric@anholt.net> - 2017-05-08 20:20 +0200
Re: [PATCH] drm/vc4: Enable selection in Kconfig on any BCM platform. Florian Fainelli <f.fainelli@gmail.com> - 2017-05-08 20:40 +0200
Re: [PATCH] drm/vc4: Enable selection in Kconfig on any BCM platform. Scott Branden <scott.branden@broadcom.com> - 2017-05-08 20:40 +0200
Re: [PATCH] drm/vc4: Enable selection in Kconfig on any BCM platform. Eric Anholt <eric@anholt.net> - 2017-05-08 21:10 +0200
csiph-web