Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637268

Re: [PATCH] drm/i915: Make vblank evade warnings optional

Show all headers | View raw

On Sun, May 07, 2017 at 07:52:14PM -0600, Jens Axboe wrote:
> On 05/07/2017 11:56 AM, Daniel Vetter wrote:
> > On Sun, May 7, 2017 at 7:46 PM, Jens Axboe <axboe@kernel.dk> wrote:
> >> On 05/07/2017 11:12 AM, ville.syrjala@linux.intel.com wrote:
> >>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >>>
> >>> Add a new Kconfig option to enable/disable the extra warnings
> >>> from the vblank evade code. For now we'll keep the warning
> >>> about an actually missed vblank always enabled as that can have
> >>> an actual user visible impact. But if we miss the deadline
> >>> othrwise there's no real need to bother the user with that.
> >>> We'll want these warnings enabled during development however
> >>> so that we can catch regressions.
> >>>
> >>> Based on the reports it looks like this is still very easy
> >>> to hit on SKL, so we have more work ahead of us to optimize
> >>> the crtiical section further.
> >>
> >> Shouldn't it just be a debug printk or something instead, so that normal
> >> people don't see it, but the folks that turn on debugging can get the
> >> info they need? Seems silly to add a kconfig option for this.
> > 
> > I guess we could keep it as debug for users, but we want to make this
> > a hard failure on our CI machines. Kconfig knob is the easiest to roll
> > out to all machines.
> 
> Wouldn't a module parameter be more useful then, as an opt-in
> to catch these violations.
> 
> Nobody is going to know wtf to set this kconfig option to.

They're all hidden behind an overall i915 debugging option which tells you
not to enable it. You won't see this.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [git pull] drm pull for v4.12 Linus Torvalds <torvalds@linux-foundation.org> - 2017-05-06 22:10 +0200
  Re: [PATCH] drm/i915: Make vblank evade warnings optional Jens Axboe <axboe@kernel.dk> - 2017-05-08 00:00 +0200
    Re: [PATCH] drm/i915: Make vblank evade warnings optional Daniel Vetter <daniel@ffwll.ch> - 2017-05-08 01:10 +0200
      Re: [PATCH] drm/i915: Make vblank evade warnings optional Jens Axboe <axboe@kernel.dk> - 2017-05-08 04:00 +0200
        Re: [PATCH] drm/i915: Make vblank evade warnings optional Daniel Vetter <daniel@ffwll.ch> - 2017-05-08 09:30 +0200
          Re: [PATCH] drm/i915: Make vblank evade warnings optional Jens Axboe <axboe@kernel.dk> - 2017-05-08 17:20 +0200
  [PATCH] drm/i915: Make vblank evade warnings optional ville.syrjala@linux.intel.com - 2017-05-08 00:30 +0200
    Re: [PATCH] drm/i915: Make vblank evade warnings optional Daniel Vetter <daniel@ffwll.ch> - 2017-05-08 09:30 +0200
  Re: [git pull] drm pull for v4.12 Daniel Vetter <daniel@ffwll.ch> - 2017-05-08 01:00 +0200

csiph-web