Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack

From	Maksim Salau <maksim.salau@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack
Date	2017-05-04 21:20 +0200
Message-ID	<tDus9-7Mu-5@gated-at.bofh.it> (permalink)
References	<tAeMW-xQ-25@gated-at.bofh.it> <tAeMW-xQ-23@gated-at.bofh.it> <tDomJ-3tZ-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> > @@ -913,6 +929,7 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device  
> 
> Don't you need to free get_version_reply here?
> 
> >  	return retval;
> >  
> >  error:
> > +	kfree(get_version_reply);
> >  	tower_delete(dev);
> >  	return retval;
> >  }  

Thank you very much, Heikki!

I was so focused on failure cases, that missed memory leak in the case
 when all calls succeeded.

I'll prepare a patch shortly to fix this.

Regards,
Maksim.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] usb: misc: legousbtower: Fix buffers on stack Maksim Salau <maksim.salau@gmail.com> - 2017-04-25 22:00 +0200
  Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-26 12:00 +0200
    Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack Maksim Salau <maksim.salau@gmail.com> - 2017-04-27 08:40 +0200
  Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2017-05-04 14:50 +0200
    Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack Maksim Salau <maksim.salau@gmail.com> - 2017-05-04 21:20 +0200

csiph-web