Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1631328

Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack

From Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack
Date 2017-04-26 12:00 +0200
Message-ID <tArTP-yp-15@gated-at.bofh.it> (permalink)
References <tAeMW-xQ-25@gated-at.bofh.it> <tAeMW-xQ-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Apr 25, 2017 at 10:49:21PM +0300, Maksim Salau wrote:
> Allocate buffers on HEAP instead of STACK for local structures
> that are to be received using usb_control_msg().
> 
> Signed-off-by: Maksim Salau <maksim.salau@gmail.com>
> Tested-by: Alfredo Rafael Vicente Boix <alviboi@gmail.com>;
> Cc: stable <stable@vger.kernel.org>
> 
> ---
>   Changes in v3:
>    * rebased against usb-next;
>    * removed Tested-by: Alfredo Rafael Vicente Boix <alviboi@gmail.com>;

I added this back, as it matters, and your change from the previous
version was trivial.

>    * removed Cc: stable@vger.kernel.org
>      since this patch doesn't apply against v4.10.12

I added this back as well :)

thanks,

greg k-h

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3] usb: misc: legousbtower: Fix buffers on stack Maksim Salau <maksim.salau@gmail.com> - 2017-04-25 22:00 +0200
  Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-26 12:00 +0200
    Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack Maksim Salau <maksim.salau@gmail.com> - 2017-04-27 08:40 +0200
  Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2017-05-04 14:50 +0200
    Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack Maksim Salau <maksim.salau@gmail.com> - 2017-05-04 21:20 +0200

csiph-web