Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

From	Dmitry Monakhov <dmonakhov@openvz.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed
Date	2017-05-03 18:10 +0200
Message-ID	<tD50K-7GP-29@gated-at.bofh.it> (permalink)
References	<tsBQl-hL-3@gated-at.bofh.it> <tsBQm-hL-35@gated-at.bofh.it> <tyaaJ-3bq-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

"Martin K. Petersen" <martin.petersen@oracle.com> writes:

> Dmitry Monakhov <dmonakhov@openvz.org> writes:
>
>> SCSI drivers do care about bip_seed so we must update it accordingly.
>
>> +	bip->bip_iter.bi_sector += bytes_done >> 9;
>
> This needs to count protection intervals. Otherwise things will break
> for block sizes different from 512 bytes.
No,
AFAIU: bip->bip_iter.bi_sector is always equals to bio->bi_iter.bi_sector
at least bip_set_seed() and bip_get_seed() relays on that.
Only bip->bip_vec must be advanced in intervals (this behavior not
changed by the patch this patch).
>
> -- 
> Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/9] bio-integrity:  bio_integrity_advance must update integrity seed Dmitry Monakhov <dmonakhov@openvz.org> - 2017-05-03 18:10 +0200
  Re: [PATCH 3/9] bio-integrity:  bio_integrity_advance must update integrity seed "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-05-03 18:20 +0200

csiph-web