Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1635108 > unrolled thread

Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 3/9] bio-integrity:  bio_integrity_advance must update integrity seed Dmitry Monakhov <dmonakhov@openvz.org> - 2017-05-03 18:10 +0200
    Re: [PATCH 3/9] bio-integrity:  bio_integrity_advance must update integrity seed "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-05-03 18:20 +0200

#1635108 — Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

"Martin K. Petersen" <martin.petersen@oracle.com> writes:

> Dmitry Monakhov <dmonakhov@openvz.org> writes:
>
>> SCSI drivers do care about bip_seed so we must update it accordingly.
>
>> +	bip->bip_iter.bi_sector += bytes_done >> 9;
>
> This needs to count protection intervals. Otherwise things will break
> for block sizes different from 512 bytes.
No,
AFAIU: bip->bip_iter.bi_sector is always equals to bio->bi_iter.bi_sector
at least bip_set_seed() and bip_get_seed() relays on that.
Only bip->bip_vec must be advanced in intervals (this behavior not
changed by the patch this patch).
>
> -- 
> Martin K. Petersen	Oracle Linux Engineering

[toc] | [next] | [standalone]

#1635122

Dmitry,

> AFAIU: bip->bip_iter.bi_sector is always equals to bio->bi_iter.bi_sector
> at least bip_set_seed() and bip_get_seed() relays on that.
> Only bip->bip_vec must be advanced in intervals (this behavior not
> changed by the patch this patch).

Yep, I realized that a bit after sending but forgot to follow up.

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web