Re: [PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc()

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc()
Date	2017-04-26 20:30 +0200
Message-ID	<tAzRo-5Yn-33@gated-at.bofh.it> (permalink)
References	<tAffX-Yq-7@gated-at.bofh.it> <tAffX-Yq-9@gated-at.bofh.it> <tAzol-5vz-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2017-04-26 at 10:57 -0700, Subhash Jadavani wrote:
> PS: ufshcd_memory_alloc() also does some DMA coherent memory allocation 
> (via dmam_alloc_coherent() APIs) and tries to print out the message on 
> allocation failure. Although i don't know "out of memory" messages will 
> be printed out by dmam_alloc_coherent() APIs or not. If it does print it 
> out then we might want to remove our local memory allocation failure log 
> messages.

Basically most everything that has a gfp_t argument does a
dump_stack() on OOM unless __GFP_NOWARN is specified by that gfp_t.

Thread

[PATCH 0/3] SCSI-UFSHCD: Fine-tuning for two function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-25 22:30 +0200
  [PATCH 2/3] scsi: ufs: Delete an error message for a failed memory  allocation in ufshcd_memory_alloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-25 22:30 +0200
    Re: [PATCH 2/3] scsi: ufs: Delete an error message for a failed  memory allocation in ufshcd_memory_alloc() Subhash Jadavani <subhashj@codeaurora.org> - 2017-04-26 20:00 +0200
      Re: scsi: ufs: Delete an error message for a failed memory allocation  in ufshcd_memory_alloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-26 20:20 +0200
      Re: [PATCH 2/3] scsi: ufs: Delete an error message for a failed  memory allocation in ufshcd_memory_alloc() Joe Perches <joe@perches.com> - 2017-04-26 20:30 +0200
        Re: Checking error messages for failed memory allocations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-26 21:00 +0200
          Re: Checking error messages for failed memory allocations Joe Perches <joe@perches.com> - 2017-04-26 21:10 +0200
            Re: Checking error messages for failed memory allocations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-26 21:20 +0200
  [PATCH 1/3] scsi: ufs: Use devm_kcalloc() in ufshcd_memory_alloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-25 22:30 +0200
    Re: [PATCH 1/3] scsi: ufs: Use devm_kcalloc() in  ufshcd_memory_alloc() Subhash Jadavani <subhashj@codeaurora.org> - 2017-04-26 20:00 +0200
  [PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in  ufshcd_exception_event_handler() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-25 22:40 +0200
    Re: [PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in  ufshcd_exception_event_handler() Subhash Jadavani <subhashj@codeaurora.org> - 2017-04-26 20:10 +0200

csiph-web