Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1631631

Re: [PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc()

Show all headers | View raw

On 2017-04-25 13:28, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 25 Apr 2017 21:50:43 +0200
> 
> The script "checkpatch.pl" pointed information out like the following.
> 
> WARNING: Possible unnecessary 'out of memory' message
> 
> Thus remove such a statement here.
> 
> Link:
> http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/scsi/ufs/ufshcd.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index ce385911a20e..5216e33e61a3 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -3274,8 +3274,7 @@ static int ufshcd_memory_alloc(struct ufs_hba 
> *hba)
>  				GFP_KERNEL);
> -	if (!hba->lrb) {
> -		dev_err(hba->dev, "LRB Memory allocation failed\n");
> +	if (!hba->lrb)
>  		goto out;
> -	}
> +
>  	return 0;
>  out:
>  	return -ENOMEM;

Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>

PS: ufshcd_memory_alloc() also does some DMA coherent memory allocation 
(via dmam_alloc_coherent() APIs) and tries to print out the message on 
allocation failure. Although i don't know "out of memory" messages will 
be printed out by dmam_alloc_coherent() APIs or not. If it does print it 
out then we might want to remove our local memory allocation failure log 
messages.


-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] SCSI-UFSHCD: Fine-tuning for two function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-25 22:30 +0200
  [PATCH 2/3] scsi: ufs: Delete an error message for a failed memory  allocation in ufshcd_memory_alloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-25 22:30 +0200
    Re: [PATCH 2/3] scsi: ufs: Delete an error message for a failed  memory allocation in ufshcd_memory_alloc() Subhash Jadavani <subhashj@codeaurora.org> - 2017-04-26 20:00 +0200
      Re: scsi: ufs: Delete an error message for a failed memory allocation  in ufshcd_memory_alloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-26 20:20 +0200
      Re: [PATCH 2/3] scsi: ufs: Delete an error message for a failed  memory allocation in ufshcd_memory_alloc() Joe Perches <joe@perches.com> - 2017-04-26 20:30 +0200
        Re: Checking error messages for failed memory allocations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-26 21:00 +0200
          Re: Checking error messages for failed memory allocations Joe Perches <joe@perches.com> - 2017-04-26 21:10 +0200
            Re: Checking error messages for failed memory allocations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-26 21:20 +0200
  [PATCH 1/3] scsi: ufs: Use devm_kcalloc() in ufshcd_memory_alloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-25 22:30 +0200
    Re: [PATCH 1/3] scsi: ufs: Use devm_kcalloc() in  ufshcd_memory_alloc() Subhash Jadavani <subhashj@codeaurora.org> - 2017-04-26 20:00 +0200
  [PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in  ufshcd_exception_event_handler() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-25 22:40 +0200
    Re: [PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in  ufshcd_exception_event_handler() Subhash Jadavani <subhashj@codeaurora.org> - 2017-04-26 20:10 +0200

csiph-web