Re: [PATCH 2/2] perf tools: Support end symbols with no size for filters

From	Andi Kleen <ak@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] perf tools: Support end symbols with no size for filters
Date	2017-02-10 00:10 +0100
Message-ID	<t960F-3Z2-7@gated-at.bofh.it> (permalink)
References	<t6UmZ-7Sg-3@gated-at.bofh.it> <t6UmZ-7Sg-1@gated-at.bofh.it> <t7RwK-5sW-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> > -		no_size = !!size;
> 
> Erk!  Isn't the logic is the wrong way around here.  Sorry!
> i.e. should be:

Yes it works with that change too.

> 
> diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
> index c5a6e0b12452..78bd632f144d 100644
> --- a/tools/perf/util/auxtrace.c
> +++ b/tools/perf/util/auxtrace.c
> @@ -1826,7 +1826,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt)
>  		filt->addr = start;
>  		if (filt->range && !filt->size && !filt->sym_to) {
>  			filt->size = size;
> -			no_size = !!size;
> +			no_size = !size;
>  		}
>  	}
>  
> @@ -1840,7 +1840,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt)
>  		if (err)
>  			return err;
>  		filt->size = start + size - filt->addr;
> -		no_size = !!size;
> +		no_size = !size;
>  	}
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] perf/core: Allow global address filtering for kernel code Andi Kleen <andi@firstfloor.org> - 2017-02-03 23:20 +0100
  [PATCH 2/2] perf tools: Support end symbols with no size for filters Andi Kleen <andi@firstfloor.org> - 2017-02-03 23:20 +0100
    Re: [PATCH 2/2] perf tools: Support end symbols with no size for  filters Adrian Hunter <adrian.hunter@intel.com> - 2017-02-06 14:30 +0100
      Re: [PATCH 2/2] perf tools: Support end symbols with no size for  filters Andi Kleen <ak@linux.intel.com> - 2017-02-10 00:10 +0100

csiph-web