Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1578020
| Path | csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Andi Kleen <ak@linux.intel.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] perf tools: Support end symbols with no size for filters |
| Date | Fri, 10 Feb 2017 00:10:01 +0100 |
| Message-ID | <t960F-3Z2-7@gated-at.bofh.it> (permalink) |
| References | <t6UmZ-7Sg-3@gated-at.bofh.it> <t6UmZ-7Sg-1@gated-at.bofh.it> <t7RwK-5sW-23@gated-at.bofh.it> |
| X-Extloop1 | 1 |
| X-Ironport-Av | E=Sophos;i="5.35,138,1484035200"; d="scan'208";a="1105370208" |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.7.1 (2016-10-04) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 29 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Andi Kleen <andi@firstfloor.org>, peterz@infradead.org, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org |
| X-Original-Date | Thu, 9 Feb 2017 14:59:27 -0800 |
| X-Original-Message-ID | <20170209225927.GB15301@tassilo.jf.intel.com> |
| X-Original-References | <20170203221830.22354-1-andi@firstfloor.org> <20170203221830.22354-2-andi@firstfloor.org> <33fb6f80-a355-d093-0237-f8cb39ab0de7@intel.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1578020 |
Show key headers only | View raw
> > - no_size = !!size;
>
> Erk! Isn't the logic is the wrong way around here. Sorry!
> i.e. should be:
Yes it works with that change too.
>
> diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
> index c5a6e0b12452..78bd632f144d 100644
> --- a/tools/perf/util/auxtrace.c
> +++ b/tools/perf/util/auxtrace.c
> @@ -1826,7 +1826,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt)
> filt->addr = start;
> if (filt->range && !filt->size && !filt->sym_to) {
> filt->size = size;
> - no_size = !!size;
> + no_size = !size;
> }
> }
>
> @@ -1840,7 +1840,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt)
> if (err)
> return err;
> filt->size = start + size - filt->addr;
> - no_size = !!size;
> + no_size = !size;
> }
>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 1/2] perf/core: Allow global address filtering for kernel code Andi Kleen <andi@firstfloor.org> - 2017-02-03 23:20 +0100
[PATCH 2/2] perf tools: Support end symbols with no size for filters Andi Kleen <andi@firstfloor.org> - 2017-02-03 23:20 +0100
Re: [PATCH 2/2] perf tools: Support end symbols with no size for filters Adrian Hunter <adrian.hunter@intel.com> - 2017-02-06 14:30 +0100
Re: [PATCH 2/2] perf tools: Support end symbols with no size for filters Andi Kleen <ak@linux.intel.com> - 2017-02-10 00:10 +0100
csiph-web