Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1575581

Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set

Show all headers | View raw

On 07/02/17 11:56, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The error check on err is redundant as it is being checked
> previously each time it has been updated.  Remove this redundant
> check.
> 
> Detected with CoverityScan, CID#140030("Logically dead code")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  net/bridge/br_netlink.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
> index fc5d885..cdc4e2a 100644
> --- a/net/bridge/br_netlink.c
> +++ b/net/bridge/br_netlink.c
> @@ -612,9 +612,6 @@ static int br_afspec(struct net_bridge *br,
>  				return err;
>  			break;
>  		}
> -
> -		if (err)
> -			return err;
>  	}
>  
>  	return err;
> 

Actually that code can be reduced further, I'll follow up with a patch later.

Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH][net-next] net: bridge: remove redundant check to see if err is set Colin King <colin.king@canonical.com> - 2017-02-07 12:00 +0100
  Re: [PATCH][net-next] net: bridge: remove redundant check to see if  err is set Nikolay Aleksandrov <nikolay@cumulusnetworks.com> - 2017-02-07 12:40 +0100
    Re: [PATCH][net-next] net: bridge: remove redundant check to see if  err is set Colin Ian King <colin.king@canonical.com> - 2017-02-07 12:50 +0100
  Re: [PATCH][net-next] net: bridge: remove redundant check to see  if err is set David Miller <davem@davemloft.net> - 2017-02-07 20:20 +0100

csiph-web