Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1575559 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-02-07 12:00 +0100 |
| Last post | 2017-02-07 20:20 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH][net-next] net: bridge: remove redundant check to see if err is set Colin King <colin.king@canonical.com> - 2017-02-07 12:00 +0100
Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set Nikolay Aleksandrov <nikolay@cumulusnetworks.com> - 2017-02-07 12:40 +0100
Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set Colin Ian King <colin.king@canonical.com> - 2017-02-07 12:50 +0100
Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set David Miller <davem@davemloft.net> - 2017-02-07 20:20 +0100
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-02-07 12:00 +0100 |
| Subject | [PATCH][net-next] net: bridge: remove redundant check to see if err is set |
| Message-ID | <t8bF8-1Lm-11@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The error check on err is redundant as it is being checked
previously each time it has been updated. Remove this redundant
check.
Detected with CoverityScan, CID#140030("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/bridge/br_netlink.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index fc5d885..cdc4e2a 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -612,9 +612,6 @@ static int br_afspec(struct net_bridge *br,
return err;
break;
}
-
- if (err)
- return err;
}
return err;
--
2.10.2
[toc] | [next] | [standalone]
| From | Nikolay Aleksandrov <nikolay@cumulusnetworks.com> |
|---|---|
| Date | 2017-02-07 12:40 +0100 |
| Subject | Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set |
| Message-ID | <t8chQ-2ff-29@gated-at.bofh.it> |
| In reply to | #1575559 |
On 07/02/17 11:56, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The error check on err is redundant as it is being checked
> previously each time it has been updated. Remove this redundant
> check.
>
> Detected with CoverityScan, CID#140030("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/bridge/br_netlink.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
> index fc5d885..cdc4e2a 100644
> --- a/net/bridge/br_netlink.c
> +++ b/net/bridge/br_netlink.c
> @@ -612,9 +612,6 @@ static int br_afspec(struct net_bridge *br,
> return err;
> break;
> }
> -
> - if (err)
> - return err;
> }
>
> return err;
>
Actually that code can be reduced further, I'll follow up with a patch later.
Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
[toc] | [prev] | [next] | [standalone]
| From | Colin Ian King <colin.king@canonical.com> |
|---|---|
| Date | 2017-02-07 12:50 +0100 |
| Subject | Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set |
| Message-ID | <t8crv-2iU-13@gated-at.bofh.it> |
| In reply to | #1575581 |
..and one more thing, in net/bridge/br_netlink_tunnel.c,
__get_num_vlan_tunnel_infos, are the args to vlan_tunnel_id_isrange()
the wrong way around? I'm not 100% sure, but I'd thought I'd flag it up.
if (v_start) {
if ((v_end->vid - v->vid) > 0 &&
vlan_tunnel_id_isrange(v_end, v) > 0)
num_tinfos += 2;
else
num_tinfos += 1;
}
On 07/02/17 11:30, Nikolay Aleksandrov wrote:
> On 07/02/17 11:56, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The error check on err is redundant as it is being checked
>> previously each time it has been updated. Remove this redundant
>> check.
>>
>> Detected with CoverityScan, CID#140030("Logically dead code")
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> net/bridge/br_netlink.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
>> index fc5d885..cdc4e2a 100644
>> --- a/net/bridge/br_netlink.c
>> +++ b/net/bridge/br_netlink.c
>> @@ -612,9 +612,6 @@ static int br_afspec(struct net_bridge *br,
>> return err;
>> break;
>> }
>> -
>> - if (err)
>> - return err;
>> }
>>
>> return err;
>>
>
> Actually that code can be reduced further, I'll follow up with a patch later.
>
> Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-02-07 20:20 +0100 |
| Subject | Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set |
| Message-ID | <t8jsZ-6U2-9@gated-at.bofh.it> |
| In reply to | #1575559 |
From: Colin King <colin.king@canonical.com>
Date: Tue, 7 Feb 2017 10:56:38 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> The error check on err is redundant as it is being checked
> previously each time it has been updated. Remove this redundant
> check.
>
> Detected with CoverityScan, CID#140030("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web