Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1575502

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

From "Valo, Kalle" <kvalo@qca.qualcomm.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()
Date 2017-02-07 10:20 +0100
Message-ID <t8a6m-VT-19@gated-at.bofh.it> (permalink)
References <t6mOm-2Do-7@gated-at.bofh.it> <t6sh4-6ho-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Adrian Chadd <adrian@freebsd.org> writes:

> Removing this method makes the diff to FreeBSD larger, as "vif" in
> FreeBSD is a different pointer.
>
> (Yes, I have ath10k on freebsd working and I'd like to find a way to
> reduce the diff moving forward.)

I don't like this "(void *) vif->drv_priv" style that much either but
apparently it's commonly used in Linux wireless code and already parts
of ath10k. So this patch just unifies the coding style.

-- 
Kalle Valo

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Amadeusz Sławiński          <amadeusz.slawinski@tieto.com> - 2017-02-02 11:30 +0100
  [PATCH 3/3] ath10k: fix comment Amadeusz Sławiński          <amadeusz.slawinski@tieto.com> - 2017-02-02 11:30 +0100
  Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Adrian Chadd <adrian@freebsd.org> - 2017-02-02 17:20 +0100
    Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() "Valo, Kalle" <kvalo@qca.qualcomm.com> - 2017-02-07 10:20 +0100
      Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Ben Greear <greearb@candelatech.com> - 2017-02-07 15:50 +0100
        Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() "Valo, Kalle" <kvalo@qca.qualcomm.com> - 2017-02-10 08:10 +0100
          Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Adrian Chadd <adrian@freebsd.org> - 2017-02-10 08:20 +0100
            Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Joe Perches <joe@perches.com> - 2017-02-10 08:40 +0100
              Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Adrian Chadd <adrian@freebsd.org> - 2017-02-10 16:40 +0100
          Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Ben Greear <greearb@candelatech.com> - 2017-02-10 18:40 +0100

csiph-web