Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1577628
| From | Paul Durrant <paul.durrant@citrix.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs |
| Date | 2017-02-09 15:20 +0100 |
| Message-ID | <t8XJL-7cN-1@gated-at.bofh.it> (permalink) |
| References | <t8XJL-7cN-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The code goes so far as to set the default return code to -ENOSYS but then overrides this to -EINVAL in the switch() statement's default case. This patch removes this pointless and incorrect override. Signed-off-by: Paul Durrant <paul.durrant@citrix.com> --- Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: Juergen Gross <jgross@suse.com> --- drivers/xen/privcmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 6e3306f..b4e5e27 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -572,7 +572,6 @@ static long privcmd_ioctl(struct file *file, break; default: - ret = -EINVAL; break; } -- 2.1.4
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs Paul Durrant <paul.durrant@citrix.com> - 2017-02-09 15:20 +0100
Re: [Xen-devel] [PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs "Jan Beulich" <JBeulich@suse.com> - 2017-02-09 15:50 +0100
RE: [Xen-devel] [PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs Paul Durrant <Paul.Durrant@citrix.com> - 2017-02-09 16:40 +0100
Re: [Xen-devel] [PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-09 20:40 +0100
csiph-web