Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577702

RE: [Xen-devel] [PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs

From Paul Durrant <Paul.Durrant@citrix.com>
Newsgroups linux.kernel
Subject RE: [Xen-devel] [PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs
Date 2017-02-09 16:40 +0100
Message-ID <t8YZd-7Tl-33@gated-at.bofh.it> (permalink)
References <t8XJL-7cN-3@gated-at.bofh.it> <t8XJL-7cN-1@gated-at.bofh.it> <t8YcO-7mZ-9@gated-at.bofh.it> <t8YZd-7Tl-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: Boris Ostrovsky [mailto:boris.ostrovsky@oracle.com]
> Sent: 09 February 2017 15:26
> To: Jan Beulich <JBeulich@suse.com>; Paul Durrant
> <Paul.Durrant@citrix.com>
> Cc: xen-devel@lists.xenproject.org; Juergen Gross <JGross@suse.com>;
> linux-kernel@vger.kernel.org
> Subject: Re: [Xen-devel] [PATCH 1/3] xen/privcmd: return -ENOSYS for
> unimplemented IOCTLs
> 
> 
> 
> On 02/09/2017 09:40 AM, Jan Beulich wrote:
> >>>> On 09.02.17 at 15:17, <paul.durrant@citrix.com> wrote:
> >> The code goes so far as to set the default return code to -ENOSYS but
> >> then overrides this to -EINVAL in the switch() statement's default
> >> case.
> >
> > If you already change this, isn't -ENOTTY the traditional way of
> > indicating unsupported ioctls?
> 
> In fact, a while ago David submitted a patch to do just that:
> 
> https://lists.xenproject.org/archives/html/xen-devel/2016-
> 08/msg00744.html
> 
> but it never went anywhere.
> 
> My question is whether anyone might be relying on current error return
> behavior.

I doubt it. It's certainly not a safe thing to do anyway. I'll change to -ENOTTY in v2 of the patch.

  Paul

> 
> 
> -boris

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs Paul Durrant <paul.durrant@citrix.com> - 2017-02-09 15:20 +0100
  Re: [Xen-devel] [PATCH 1/3] xen/privcmd: return -ENOSYS for  unimplemented IOCTLs "Jan Beulich" <JBeulich@suse.com> - 2017-02-09 15:50 +0100
    RE: [Xen-devel] [PATCH 1/3] xen/privcmd: return -ENOSYS for  unimplemented IOCTLs Paul Durrant <Paul.Durrant@citrix.com> - 2017-02-09 16:40 +0100
    Re: [Xen-devel] [PATCH 1/3] xen/privcmd: return -ENOSYS for  unimplemented IOCTLs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-09 20:40 +0100

csiph-web