Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1575370

[PATCH V2 1/5] thermal: devfreq: Simplify expression

From Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups linux.kernel
Subject [PATCH V2 1/5] thermal: devfreq: Simplify expression
Date 2017-02-07 05:20 +0100
Message-ID <t85q1-6db-3@gated-at.bofh.it> (permalink)
References <t85q1-6db-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


There is no need to check for IS_ERR() as we are looking for a very
particular error value here. Drop the first check.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/thermal/devfreq_cooling.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c
index ba7a5cd994dc..cf71550b9d00 100644
--- a/drivers/thermal/devfreq_cooling.c
+++ b/drivers/thermal/devfreq_cooling.c
@@ -222,7 +222,7 @@ get_static_power(struct devfreq_cooling_device *dfc, unsigned long freq)
 		return 0;
 
 	opp = dev_pm_opp_find_freq_exact(dev, freq, true);
-	if (IS_ERR(opp) && (PTR_ERR(opp) == -ERANGE))
+	if (PTR_ERR(opp) == -ERANGE)
 		opp = dev_pm_opp_find_freq_exact(dev, freq, false);
 
 	voltage = dev_pm_opp_get_voltage(opp) / 1000; /* mV */
-- 
2.7.1.410.g6faf27b

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V2 0/5] thermal: minor cleanup/fixes Viresh Kumar <viresh.kumar@linaro.org> - 2017-02-07 05:20 +0100
  [PATCH V2 1/5] thermal: devfreq: Simplify expression Viresh Kumar <viresh.kumar@linaro.org> - 2017-02-07 05:20 +0100
    [PATCH V2 2/5] thermal: devfreq_cooling: Replace dev_warn with dev_err Viresh Kumar <viresh.kumar@linaro.org> - 2017-02-07 05:20 +0100

csiph-web