[PATCH V2 2/5] thermal: devfreq_cooling: Replace dev_warn with dev_err

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	[PATCH V2 2/5] thermal: devfreq_cooling: Replace dev_warn with dev_err
Date	2017-02-07 05:20 +0100
Message-ID	<t85q1-6db-19@gated-at.bofh.it> (permalink)
References	<t85q1-6db-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

There isn't much the user can do on seeing this warning, as the hardware
is actually okay. dev_err suits much better here.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/thermal/devfreq_cooling.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c
index cf71550b9d00..218ccc30c7ad 100644
--- a/drivers/thermal/devfreq_cooling.c
+++ b/drivers/thermal/devfreq_cooling.c
@@ -229,9 +229,9 @@ get_static_power(struct devfreq_cooling_device *dfc, unsigned long freq)
 	dev_pm_opp_put(opp);
 
 	if (voltage == 0) {
-		dev_warn_ratelimited(dev,
-				     "Failed to get voltage for frequency %lu: %ld\n",
-				     freq, IS_ERR(opp) ? PTR_ERR(opp) : 0);
+		dev_err_ratelimited(dev,
+				    "Failed to get voltage for frequency %lu: %ld\n",
+				    freq, IS_ERR(opp) ? PTR_ERR(opp) : 0);
 		return 0;
 	}
 
-- 
2.7.1.410.g6faf27b

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2 0/5] thermal: minor cleanup/fixes Viresh Kumar <viresh.kumar@linaro.org> - 2017-02-07 05:20 +0100
  [PATCH V2 1/5] thermal: devfreq: Simplify expression Viresh Kumar <viresh.kumar@linaro.org> - 2017-02-07 05:20 +0100
    [PATCH V2 2/5] thermal: devfreq_cooling: Replace dev_warn with dev_err Viresh Kumar <viresh.kumar@linaro.org> - 2017-02-07 05:20 +0100

csiph-web