Re: [PATCH] pinctrl: samsung: mark PM functions as __maybe_unused

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: samsung: mark PM functions as __maybe_unused
Date	2017-02-06 11:10 +0100
Message-ID	<t7Opb-3AB-7@gated-at.bofh.it> (permalink)
References	<t65Nw-8ap-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 1, 2017 at 5:16 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> The rework of the suspend/resume handling uses the wrong #ifdef check, leading
> to a build warning without CONFIG_PM_SLEEP:
>
> drivers/pinctrl/samsung/pinctrl-samsung.c:1142:12: error: 'samsung_pinctrl_resume' defined but not used [-Werror=unused-function]
> drivers/pinctrl/samsung/pinctrl-samsung.c:1092:12: error: 'samsung_pinctrl_suspend' defined but not used [-Werror=unused-function]
>
> Using a __maybe_unused annotation instead of the #ifdef is a simple way to
> avoid this problem class.
>
> Fixes: 2b24efa8e5c5 ("pinctrl: samsung: Replace syscore ops with standard platform device pm_ops")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied with Marek's ACK.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: samsung: mark PM functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-02-01 17:20 +0100
  Re: [PATCH] pinctrl: samsung: mark PM functions as __maybe_unused Marek Szyprowski <m.szyprowski@samsung.com> - 2017-02-02 08:00 +0100
  Re: [PATCH] pinctrl: samsung: mark PM functions as __maybe_unused Linus Walleij <linus.walleij@linaro.org> - 2017-02-06 11:10 +0100

csiph-web