Re: [PATCH] pinctrl: samsung: mark PM functions as __maybe_unused

Path	csiph.com!weretis.net!feeder6.news.weretis.net!feeder5.news.weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: samsung: mark PM functions as __maybe_unused
Date	Mon, 06 Feb 2017 11:10:01 +0100
Message-ID	<t7Opb-3AB-7@gated-at.bofh.it> (permalink)
References	<t65Nw-8ap-11@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=l9K+GNfNxBq/R9O7gjqSruPS+QybovbwNLz/Ee04LJA=; b=TkUhuOdyyHGUzYNTilvFBhqUi6Ta5MIZNY52y7Hbe7SnhWFeXJErPH9IVQvHlN91mh dqo2h60//J0jMbOGqy68cuq9bbBkLUYKc7sBXTMX72iihr2f457No07nXRUsqFBx1YIK iSBTWLtXiUV8Vuj7jsHOn4cBTO5YV+EsexwcM=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=l9K+GNfNxBq/R9O7gjqSruPS+QybovbwNLz/Ee04LJA=; b=eLCcevU6pb0oD1/4M8H6moHo2ySSSf7hqGl8JWxGjvhQMMKSojDeOwN9oIaiAZMaMH JZrtfQuo6Rb7pxz/iRTLYFdDy5apX4Hl+mfkLmWSDEXiP8HSp+lk6DGE4JSutrJMp+87 0IX+6Ikw1EBor+pLvMY6NXH5/lPNUKYOee+0BvaqaE5D5hZ1ARwc3lAw+mI3n5q+rYOn msoIwvoMOYkinXrnX8VDoyooR8c8b7y11y7CCiM1uY+dHLGH9o/cR+vTgYmoJZAVswj9 ofWxDlKF2JPkZJ1cB1jW9CuNwsxYoux9Z9f+M8jg6GQ91CmoIGhfKcMHfpH54ha4O6jX IJhA==
X-Gm-Message-State	AMke39mkMlWZe2T/iaincK5XfEn0pBEPCYuK7OIQBY2L/8E68S4RLjcpylZgiax/lV43tN3nkGoqCHDf0QRLa4Eh
X-Received	by 10.107.15.12 with SMTP id x12mr5946007ioi.61.1486375493819; Mon, 06 Feb 2017 02:04:53 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	18
Organization	linux.* mail to news gateway
X-Original-Cc	Tomasz Figa <tomasz.figa@gmail.com>, Krzysztof Kozlowski <krzk@kernel.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Marek Szyprowski <m.szyprowski@samsung.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, linux-samsung-soc <linux-samsung-soc@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 6 Feb 2017 11:04:52 +0100
X-Original-Message-ID	<CACRpkdYBL_4caeSkD4aXqGCJ0XF=S_pQ24J8pBPCacDyzdow0g@mail.gmail.com>
X-Original-References	<20170201161636.2109091-1-arnd@arndb.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1574517

Show key headers only | View raw

On Wed, Feb 1, 2017 at 5:16 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> The rework of the suspend/resume handling uses the wrong #ifdef check, leading
> to a build warning without CONFIG_PM_SLEEP:
>
> drivers/pinctrl/samsung/pinctrl-samsung.c:1142:12: error: 'samsung_pinctrl_resume' defined but not used [-Werror=unused-function]
> drivers/pinctrl/samsung/pinctrl-samsung.c:1092:12: error: 'samsung_pinctrl_suspend' defined but not used [-Werror=unused-function]
>
> Using a __maybe_unused annotation instead of the #ifdef is a simple way to
> avoid this problem class.
>
> Fixes: 2b24efa8e5c5 ("pinctrl: samsung: Replace syscore ops with standard platform device pm_ops")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied with Marek's ACK.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: samsung: mark PM functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-02-01 17:20 +0100
  Re: [PATCH] pinctrl: samsung: mark PM functions as __maybe_unused Marek Szyprowski <m.szyprowski@samsung.com> - 2017-02-02 08:00 +0100
  Re: [PATCH] pinctrl: samsung: mark PM functions as __maybe_unused Linus Walleij <linus.walleij@linaro.org> - 2017-02-06 11:10 +0100

csiph-web