Re: [PATCH] [linux-next] staging: greybus: Remove duplicate include file

From	Johan Hovold <johan@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [linux-next] staging: greybus: Remove duplicate include file
Date	2017-02-03 13:50 +0100
Message-ID	<t6Lto-1DF-15@gated-at.bofh.it> (permalink)
References	<t60Xv-5a0-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 01, 2017 at 08:05:07PM +0900, Masanari Iida wrote:
> This patch removed duplicated include line.
> 
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> ---
>  drivers/staging/greybus/authentication.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/authentication.c b/drivers/staging/greybus/authentication.c
> index 168626ba0c03..6c5dcb1c226b 100644
> --- a/drivers/staging/greybus/authentication.c
> +++ b/drivers/staging/greybus/authentication.c
> @@ -16,7 +16,6 @@
>  
>  #include "greybus_authentication.h"
>  #include "firmware.h"
> -#include "greybus.h"

Please remove the other "greybus.h" include that precedes the "system"
includes instead.

>  
>  #define CAP_TIMEOUT_MS		1000

Also add a component prefix to your subject (i.e. "staging: greybus:
authentication: remove...").

Thanks,
Johan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [linux-next] staging: greybus: Remove duplicate include file Masanari Iida <standby24x7@gmail.com> - 2017-02-01 12:10 +0100
  Re: [PATCH] [linux-next] staging: greybus: Remove duplicate include  file Johan Hovold <johan@kernel.org> - 2017-02-03 13:50 +0100

csiph-web