Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1571483 > unrolled thread

[PATCH] [linux-next] staging: greybus: Remove duplicate include file

Started byMasanari Iida <standby24x7@gmail.com>
First post2017-02-01 12:10 +0100
Last post2017-02-03 13:50 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] [linux-next] staging: greybus: Remove duplicate include file Masanari Iida <standby24x7@gmail.com> - 2017-02-01 12:10 +0100
    Re: [PATCH] [linux-next] staging: greybus: Remove duplicate include  file Johan Hovold <johan@kernel.org> - 2017-02-03 13:50 +0100

#1571483 — [PATCH] [linux-next] staging: greybus: Remove duplicate include file

FromMasanari Iida <standby24x7@gmail.com>
Date2017-02-01 12:10 +0100
Subject[PATCH] [linux-next] staging: greybus: Remove duplicate include file
Message-ID<t60Xv-5a0-7@gated-at.bofh.it>
This patch removed duplicated include line.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
 drivers/staging/greybus/authentication.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/greybus/authentication.c b/drivers/staging/greybus/authentication.c
index 168626ba0c03..6c5dcb1c226b 100644
--- a/drivers/staging/greybus/authentication.c
+++ b/drivers/staging/greybus/authentication.c
@@ -16,7 +16,6 @@
 
 #include "greybus_authentication.h"
 #include "firmware.h"
-#include "greybus.h"
 
 #define CAP_TIMEOUT_MS		1000
 
-- 
2.11.0.616.g8f60064c1f53

[toc] | [next] | [standalone]


#1573067 — Re: [PATCH] [linux-next] staging: greybus: Remove duplicate include file

FromJohan Hovold <johan@kernel.org>
Date2017-02-03 13:50 +0100
SubjectRe: [PATCH] [linux-next] staging: greybus: Remove duplicate include file
Message-ID<t6Lto-1DF-15@gated-at.bofh.it>
In reply to#1571483
On Wed, Feb 01, 2017 at 08:05:07PM +0900, Masanari Iida wrote:
> This patch removed duplicated include line.
> 
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> ---
>  drivers/staging/greybus/authentication.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/authentication.c b/drivers/staging/greybus/authentication.c
> index 168626ba0c03..6c5dcb1c226b 100644
> --- a/drivers/staging/greybus/authentication.c
> +++ b/drivers/staging/greybus/authentication.c
> @@ -16,7 +16,6 @@
>  
>  #include "greybus_authentication.h"
>  #include "firmware.h"
> -#include "greybus.h"

Please remove the other "greybus.h" include that precedes the "system"
includes instead.

>  
>  #define CAP_TIMEOUT_MS		1000

Also add a component prefix to your subject (i.e. "staging: greybus:
authentication: remove...").

Thanks,
Johan

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web