Re: [PATCH] gianfar: synchronize DMA API usage by free_skb_rx_queue w/ gfar_new_page

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gianfar: synchronize DMA API usage by free_skb_rx_queue w/ gfar_new_page
Date	2017-01-30 17:30 +0100
Message-ID	<t5n06-6b0-19@gated-at.bofh.it> (permalink)
References	<t4XoZ-7qU-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Arseny Solokha <asolokha@kb.kras.ru>
Date: Sun, 29 Jan 2017 19:52:20 +0700

> From: Arseny Solokha <asolokha@kb.kras.ru>
> 
> In spite of switching to paged allocation of Rx buffers, the driver still
> called dma_unmap_single() in the Rx queues tear-down path.
> 
> The DMA region unmapping code in free_skb_rx_queue() basically predates
> the introduction of paged allocation to the driver. While being refactored,
> it apparently hasn't reflected the change in the DMA API usage by its
> counterpart gfar_new_page().
> 
> As a result, setting an interface to the DOWN state now yields the following:
 ...
> Even though the issue was discovered in 4.9 kernel, the code in question
> is identical in the current net and net-next trees.
> 
> Fixes: 75354148ce69 ("gianfar: Add paged allocation and Rx S/G")
> Signed-off-by: Arseny Solokha <asolokha@kb.kras.ru>

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] gianfar: synchronize DMA API usage by free_skb_rx_queue w/ gfar_new_page Arseny Solokha <asolokha@kb.kras.ru> - 2017-01-29 14:10 +0100
  RE: [PATCH] gianfar: synchronize DMA API usage by free_skb_rx_queue  w/ gfar_new_page Claudiu Manoil <claudiu.manoil@nxp.com> - 2017-01-30 10:10 +0100
  Re: [PATCH] gianfar: synchronize DMA API usage by  free_skb_rx_queue w/ gfar_new_page David Miller <davem@davemloft.net> - 2017-01-30 17:30 +0100

csiph-web