Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1569483

RE: [PATCH] gianfar: synchronize DMA API usage by free_skb_rx_queue w/ gfar_new_page

Show all headers | View raw

>-----Original Message-----
>From: Arseny Solokha [mailto:asolokha@kb.kras.ru]
>Sent: Sunday, January 29, 2017 2:52 PM
>To: Claudiu Manoil <claudiu.manoil@nxp.com>
>Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Arseny Solokha
><asolokha@kb.kras.ru>
>Subject: [PATCH] gianfar: synchronize DMA API usage by free_skb_rx_queue w/
>gfar_new_page
>
>From: Arseny Solokha <asolokha@kb.kras.ru>
>
>In spite of switching to paged allocation of Rx buffers, the driver still
>called dma_unmap_single() in the Rx queues tear-down path.
>

Except for the dma-debug part generating the warning, the implementation of 
dma_unmap_single() looks identical to dma_unmap_page(), both wrappers calling 
ops->unmap_page() with same params.
But for consistency, dma_unmap_page() seems the better choice indeed.
Thanks.

Acked-by: Claudiu Manoil <claudiu.manoil@nxp.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] gianfar: synchronize DMA API usage by free_skb_rx_queue w/ gfar_new_page Arseny Solokha <asolokha@kb.kras.ru> - 2017-01-29 14:10 +0100
  RE: [PATCH] gianfar: synchronize DMA API usage by free_skb_rx_queue  w/ gfar_new_page Claudiu Manoil <claudiu.manoil@nxp.com> - 2017-01-30 10:10 +0100
  Re: [PATCH] gianfar: synchronize DMA API usage by  free_skb_rx_queue w/ gfar_new_page David Miller <davem@davemloft.net> - 2017-01-30 17:30 +0100

csiph-web