Re: [PATCH 3/4] ARM: nommu: display vectors base

From	Russell King - ARM Linux <linux@armlinux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] ARM: nommu: display vectors base
Date	2017-01-30 13:20 +0100
Message-ID	<t5j6a-3SD-5@gated-at.bofh.it> (permalink)
References	<t15bt-o6-55@gated-at.bofh.it> <t15Eu-O4-25@gated-at.bofh.it> <t16TU-1vQ-13@gated-at.bofh.it> <t1kWS-23z-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 19, 2017 at 06:46:32PM +0530, Afzal Mohammed wrote:
> Hi,
> 
> On Wed, Jan 18, 2017 at 10:13:15PM +0000, Russell King - ARM Linux wrote:
> > On Thu, Jan 19, 2017 at 02:08:37AM +0530, afzal mohammed wrote:
> 
> > > +			MLK_ROUNDUP(vectors_base, vectors_base + PAGE_SIZE),
> > 
> > I think MLK() will do here - no need to use the rounding-up version
> > as PAGE_SIZE is a multiple of 1k.
> 
> Yes, i will replace it.
> 
> Earlier, used MLK(), got some build error, now checking again, no
> build error, i should have messed up something at that time.

Sorry for the delayed response.

With that change, you can get rid of this preprocessor conditional.
Arrange to have VECTORS_BASE defined to vectors_base in the nommu
part of asm/memory.h.  You'll also need to move the extern of that
there too.

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] ARM: v7-A !MMU support, CONFIG_VECTORS_BASE removal (almost) afzal mohammed <afzal.mohd.ma@gmail.com> - 2017-01-18 21:40 +0100
  [PATCH 4/4] ARM: nommu: remove Hivecs configuration is asm afzal mohammed <afzal.mohd.ma@gmail.com> - 2017-01-18 21:50 +0100
  [PATCH 3/4] ARM: nommu: display vectors base afzal mohammed <afzal.mohd.ma@gmail.com> - 2017-01-18 22:10 +0100
    Re: [PATCH 3/4] ARM: nommu: display vectors base Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-18 23:30 +0100
      Re: [PATCH 3/4] ARM: nommu: display vectors base Afzal Mohammed <afzal.mohd.ma@gmail.com> - 2017-01-19 14:30 +0100
        Re: [PATCH 3/4] ARM: nommu: display vectors base Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-30 13:20 +0100

csiph-web