Re: [PATCH 3/4] ARM: nommu: display vectors base

Path	csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Russell King - ARM Linux <linux@armlinux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] ARM: nommu: display vectors base
Date	Mon, 30 Jan 2017 13:20:02 +0100
Message-ID	<t5j6a-3SD-5@gated-at.bofh.it> (permalink)
References	<t15bt-o6-55@gated-at.bofh.it> <t15Eu-O4-25@gated-at.bofh.it> <t16TU-1vQ-13@gated-at.bofh.it> <t1kWS-23z-7@gated-at.bofh.it>
X-Original-To	Afzal Mohammed <afzal.mohd.ma@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2014; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=nbWOQ80BHhMqg0dlchAfWFSdZT0QXmCE9kky4CMvV8Y=; b=ARYtUfQtAiImGehxs+yvoHjSB+gtkQB8QMdibKsgcxhv3SQsBa++UNQB7SP/EHUHQBXJW3c6BfXPTExjORSXaY6QmrrDpVxkvJ4gzkncEp6GTLsr3YIrq+bu9soNtef67e4oPYemGyOAoZp3bMUkXzMLiMn2l2owhybJRowWgj4=;
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	Vladimir Murzin <vladimir.murzin@arm.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 30 Jan 2017 12:09:19 +0000
X-Original-Message-ID	<20170130120919.GP27312@n2100.armlinux.org.uk>
X-Original-References	<20170118203525.6246-1-afzal.mohd.ma@gmail.com> <20170118203837.6536-1-afzal.mohd.ma@gmail.com> <20170118221315.GP27312@n2100.armlinux.org.uk> <20170119131632.GA3862@afzalpc>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1569687

Show key headers only | View raw

On Thu, Jan 19, 2017 at 06:46:32PM +0530, Afzal Mohammed wrote:
> Hi,
> 
> On Wed, Jan 18, 2017 at 10:13:15PM +0000, Russell King - ARM Linux wrote:
> > On Thu, Jan 19, 2017 at 02:08:37AM +0530, afzal mohammed wrote:
> 
> > > +			MLK_ROUNDUP(vectors_base, vectors_base + PAGE_SIZE),
> > 
> > I think MLK() will do here - no need to use the rounding-up version
> > as PAGE_SIZE is a multiple of 1k.
> 
> Yes, i will replace it.
> 
> Earlier, used MLK(), got some build error, now checking again, no
> build error, i should have messed up something at that time.

Sorry for the delayed response.

With that change, you can get rid of this preprocessor conditional.
Arrange to have VECTORS_BASE defined to vectors_base in the nommu
part of asm/memory.h.  You'll also need to move the extern of that
there too.

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] ARM: v7-A !MMU support, CONFIG_VECTORS_BASE removal (almost) afzal mohammed <afzal.mohd.ma@gmail.com> - 2017-01-18 21:40 +0100
  [PATCH 4/4] ARM: nommu: remove Hivecs configuration is asm afzal mohammed <afzal.mohd.ma@gmail.com> - 2017-01-18 21:50 +0100
  [PATCH 3/4] ARM: nommu: display vectors base afzal mohammed <afzal.mohd.ma@gmail.com> - 2017-01-18 22:10 +0100
    Re: [PATCH 3/4] ARM: nommu: display vectors base Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-18 23:30 +0100
      Re: [PATCH 3/4] ARM: nommu: display vectors base Afzal Mohammed <afzal.mohd.ma@gmail.com> - 2017-01-19 14:30 +0100
        Re: [PATCH 3/4] ARM: nommu: display vectors base Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-30 13:20 +0100

csiph-web