Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

From	Vineeth Remanan Pillai <vineethp@amazon.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM
Date	2017-01-31 18:00 +0100
Message-ID	<t5JWF-33f-3@gated-at.bofh.it> (permalink)
References	<t1nUK-3Tq-13@gated-at.bofh.it> <t1nUK-3Tq-11@gated-at.bofh.it> <t56Vj-4UH-7@gated-at.bofh.it> <t5nt8-6kA-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/30/2017 08:47 AM, Vineeth Remanan Pillai wrote:
>
> On 01/29/2017 03:09 PM, Boris Ostrovsky wrote:
>>
>> There are couple of problems with this patch.
>> 1. The 'if' clause now evaluates to true on pretty much every call to 
>> xennet_alloc_rx_buffers().
> Thanks for catching this. In my testing I did not notice this - mostly 
> because of the nature of the workload in my testing.
I am working on a patch to revert to the old behavior and solve the Rx 
stall issue by scheduling the timer if any of the following
conditions are true:
  - unconsumed requests + new requests < NET_RX_SLOTS_MIN (old behavior)
  - skb allocations fail

Will send out the patch by next week after I can do some testing.

Thanks,
Vineeth

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and  OOM Vineeth Remanan Pillai <vineethp@amazon.com> - 2017-01-31 18:00 +0100

csiph-web