Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1570897
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Vineeth Remanan Pillai <vineethp@amazon.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM |
| Date | Tue, 31 Jan 2017 18:00:02 +0100 |
| Message-ID | <t5JWF-33f-3@gated-at.bofh.it> (permalink) |
| References | <t1nUK-3Tq-13@gated-at.bofh.it> <t1nUK-3Tq-11@gated-at.bofh.it> <t56Vj-4UH-7@gated-at.bofh.it> <t5nt8-6kA-13@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1485881611; x=1517417611; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=QBMNt7sqBDYXh7uZh4iNtPg5oneBs+qrbY5+q3EKjH8=; b=jpVXXsQ/6T8ZbbW2S0sICsCcpZ5B9vEx9g7+d6sBietE1BtFDJi7DvZ5 pziM/lh2Dp0UViekhW5GqTsU6aJgly/GwrJxMo5E+59cKhoYKqMXFuz9C MPnyBjXUAVciOuBUINEpuwUluNJJbZo36qb07UXgl9HWgEvOtFkCSGJsU U=; |
| X-Ironport-Av | E=Sophos;i="5.33,315,1477958400"; d="scan'208";a="671030920" |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset="windows-1252"; format=flowed |
| Content-Transfer-Encoding | 7bit |
| X-Originating-IP | [10.43.161.164] |
| X-Clientproxiedby | EX13D10UWA002.ant.amazon.com (10.43.160.228) To EX13D08UWC003.ant.amazon.com (10.43.162.21) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 20 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | <linux-kernel@vger.kernel.org>, David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>, Wei Liu <wei.liu2@citrix.com>, Paul Durrant <paul.durrant@citrix.com>, xen-devel <xen-devel@lists.xen.org> |
| X-Original-Date | Tue, 31 Jan 2017 08:47:25 -0800 |
| X-Original-Message-ID | <7780bf0c-9fd0-1abf-77d3-983f5e6c4e08@amazon.com> |
| X-Original-References | <1484771149-12699-1-git-send-email-vineethp@u480fcf3b67f557f68df1.ant.amazon.com> <66b10c64-936a-8001-6855-2ff1ed626642@amazon.com> <38ccfaea-0a65-a6f3-c19a-e6f9c0d4ef76@oracle.com> <989bd104-13a9-f25f-b857-24ec49781f9c@amazon.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1570897 |
Show key headers only | View raw
On 01/30/2017 08:47 AM, Vineeth Remanan Pillai wrote: > > On 01/29/2017 03:09 PM, Boris Ostrovsky wrote: >> >> There are couple of problems with this patch. >> 1. The 'if' clause now evaluates to true on pretty much every call to >> xennet_alloc_rx_buffers(). > Thanks for catching this. In my testing I did not notice this - mostly > because of the nature of the workload in my testing. I am working on a patch to revert to the old behavior and solve the Rx stall issue by scheduling the timer if any of the following conditions are true: - unconsumed requests + new requests < NET_RX_SLOTS_MIN (old behavior) - skb allocations fail Will send out the patch by next week after I can do some testing. Thanks, Vineeth
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM Vineeth Remanan Pillai <vineethp@amazon.com> - 2017-01-31 18:00 +0100
csiph-web