Re: [PATCH] tpm: fix RC value check in tpm2_seal_trusted

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tpm: fix RC value check in tpm2_seal_trusted
Date	2017-01-29 16:20 +0100
Message-ID	<t4ZqO-cH-23@gated-at.bofh.it> (permalink)
References	(1 earlier) <t3E53-7DH-17@gated-at.bofh.it> <t3QpB-6Hl-39@gated-at.bofh.it> <t3X7I-2kP-3@gated-at.bofh.it> <t48w9-M6-1@gated-at.bofh.it> <t4hzs-6qz-5@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Fri, Jan 27, 2017 at 09:24:16AM -0700, Jason Gunthorpe wrote:
> On Fri, Jan 27, 2017 at 08:43:27AM +0200, Jarkko Sakkinen wrote:
> > On Thu, Jan 26, 2017 at 11:32:52AM -0700, Jason Gunthorpe wrote:
> > > On Thu, Jan 26, 2017 at 01:27:14PM +0200, Jarkko Sakkinen wrote:
> > > 
> > > > "The error code handling is bogus as any error code that has the bits
> > > > set that TPM_RC_HASH could pass. Implemented tpm2_rc_value() helper to
> > > > parse the error value from FMT0 and FMT1 error codes to use to check the
> > > > error so that these types of mistakes is prevented in the future."
> > > 
> > > Great thanks
> > > 
> > > Jason
> > 
> > Can I put your Reviewed-by? I would like to get this into 4.11.
> 
> I'm not up to speed on the TPM2 parsing, but it looks OK based on your
> description.
> 
> Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> 
> Jason

Thanks I applied this patch to master.

/Jarkko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tpm: fix RC value check in tpm2_seal_trusted Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-25 22:10 +0100
  Re: [PATCH] tpm: fix RC value check in tpm2_seal_trusted Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-01-25 23:20 +0100
    Re: [PATCH] tpm: fix RC value check in tpm2_seal_trusted Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-26 12:30 +0100
      Re: [PATCH] tpm: fix RC value check in tpm2_seal_trusted Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-01-26 19:40 +0100
        Re: [PATCH] tpm: fix RC value check in tpm2_seal_trusted Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-27 07:50 +0100
          Re: [PATCH] tpm: fix RC value check in tpm2_seal_trusted Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-01-27 17:30 +0100
            Re: [PATCH] tpm: fix RC value check in tpm2_seal_trusted Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-29 16:20 +0100

csiph-web