[PATCH V3 net-next 02/14] net/ena: fix error handling when probe fails

From	Netanel Belgazal <netanel@annapurnalabs.com>
Newsgroups	linux.kernel
Subject	[PATCH V3 net-next 02/14] net/ena: fix error handling when probe fails
Date	2017-01-26 23:20 +0100
Message-ID	<t40yB-4uo-3@gated-at.bofh.it> (permalink)
References	<t40yB-4uo-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

When driver fails in probe, it will release all resources,
including adapter.
In case of probe failure, ena_remove should not try to
free the adapter resources.

Signed-off-by: Netanel Belgazal <netanel@annapurnalabs.com>
---
 drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 7493ea3..cb60567 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -3046,6 +3046,7 @@ static int ena_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 err_free_region:
 	ena_release_bars(ena_dev, pdev);
 err_free_ena_dev:
+	pci_set_drvdata(pdev, NULL);
 	vfree(ena_dev);
 err_disable_device:
 	pci_disable_device(pdev);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH V3 net-next 02/14] net/ena: fix error handling when probe fails Netanel Belgazal <netanel@annapurnalabs.com> - 2017-01-26 23:20 +0100
  Re: [PATCH V3 net-next 02/14] net/ena: fix error handling when probe  fails Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2017-01-28 00:40 +0100

csiph-web