[PATCH V3 net-next 02/14] net/ena: fix error handling when probe fails

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Netanel Belgazal <netanel@annapurnalabs.com>
Newsgroups	linux.kernel
Subject	[PATCH V3 net-next 02/14] net/ena: fix error handling when probe fails
Date	Thu, 26 Jan 2017 23:20:01 +0100
Message-ID	<t40yB-4uo-3@gated-at.bofh.it> (permalink)
References	<t40yB-4uo-5@gated-at.bofh.it>
X-Original-To	linux-kernel@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=annapurnalabs-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XW1kKAzfVDtMT9Q4ZVaC86uF6RI9uxvKXrHbQFOW2Ok=; b=wKN6Id+2ZyuCVSXOJDekIBU1kJfTqzHglXn9OEkOBQoSGQmrq594tKlHstg+A9sT6T rHuKuVhbXBT0vM3pKG0SAYD8vw/FQEvUHrnA949c7B/kqn8C7UYGkYZ/xneFRe27Wgj1 93earGbH1Wh9wWCRjI1fPfqpu/xy0qW9n9piudMLFP5/6d0MBbzM4afusRVdRNPtTMf/ 4aYy8kgI23LtUMhTF/ruIIE/yaC8hEEDzq63l9xGqMrdXQAhuk0fG9F3Kwnu8AMAC4iE w2dH42tzXi3GWrJVmL0GQMRIMpc7jTG9pI1w4L6QAShK4My8XYFZ6fJgmSU+2TDrDJt7 wdKA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XW1kKAzfVDtMT9Q4ZVaC86uF6RI9uxvKXrHbQFOW2Ok=; b=fIZc7wIEcIFZBz/G0d6nVQglZyESy00NzHEOhyeNFUNFRf2PaWJJErEM/0WEqMb/Nh g7JNt3ukqFOD/YXakxOWG5HLB/CxcV1UtEjChprjUBxXvlqRqbeF4YQqFfJVjqP8LPeS aOlJxzQ/kuGOGUbZXhWWOXAXdePAGIqpG0N5FcLyOW1K83/QnpEtgIf4K3ztjJ/7Ymns 6QkhtZ0rv6Mq2rsWkrLZdr4Cvx/XhJagxbRefSiMkasPO7kakuVLLVVt6e03CgHi4/PF SxejN6wzYYveJS010YmTX2ggrU6EvQe8JhYEgCWf6T7bBnAs2b/FN9n/VNaVKk6u5qKB CKbQ==
X-Gm-Message-State	AIkVDXIow+MQjquNYLA/UhJUs7ybOXmqe+54KWaT6YWECyIxnKVIPYE/UgsBJ6PvtCiz8j4w
X-Received	by 10.223.146.228 with SMTP id 91mr4642171wrn.203.1485469113873; Thu, 26 Jan 2017 14:18:33 -0800 (PST)
X-Mailer	git-send-email 2.7.4
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	Netanel Belgazal <netanel@annapurnalabs.com>, dwmw@amazon.com, zorik@annapurnalabs.com, alex@annapurnalabs.com, saeed@annapurnalabs.com, msw@amazon.com, aliguori@amazon.com, nafea@annapurnalabs.com, eric.dumazet@gmail.com
X-Original-Date	Fri, 27 Jan 2017 00:18:04 +0200
X-Original-Message-ID	<1485469096-5271-3-git-send-email-netanel@annapurnalabs.com>
X-Original-References	<1485469096-5271-1-git-send-email-netanel@annapurnalabs.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1567752

Show key headers only | View raw

When driver fails in probe, it will release all resources,
including adapter.
In case of probe failure, ena_remove should not try to
free the adapter resources.

Signed-off-by: Netanel Belgazal <netanel@annapurnalabs.com>
---
 drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 7493ea3..cb60567 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -3046,6 +3046,7 @@ static int ena_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 err_free_region:
 	ena_release_bars(ena_dev, pdev);
 err_free_ena_dev:
+	pci_set_drvdata(pdev, NULL);
 	vfree(ena_dev);
 err_disable_device:
 	pci_disable_device(pdev);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH V3 net-next 02/14] net/ena: fix error handling when probe fails Netanel Belgazal <netanel@annapurnalabs.com> - 2017-01-26 23:20 +0100
  Re: [PATCH V3 net-next 02/14] net/ena: fix error handling when probe  fails Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2017-01-28 00:40 +0100

csiph-web