Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566482

Re: [PATCH] mm/migration: make isolate_movable_page always defined

Show all headers | View raw

Hi Andrew, Minchan, and all:
My former patch "HWPOISON: soft offlining for non-lru
movable page" will cause compiled error when disable
CONFIG_MIGRATION. And this is a patch to fixe it by
define isolate_movable_page as a static inline
function with !CONFIG_MIGRATION.

Could you please help to review it ? Thanks so much~

I am so sorry about that.

Thanks.
Yisheng Xie

On 2017/1/25 18:36, Yisheng Xie wrote:
> Define isolate_movable_page as a static inline function when
> CONFIG_MIGRATION is not enable. It should return false
> here which means failed to isolate movable pages.
> 
> This patch do not have any functional change but to resolve compile
> error caused by former commit "HWPOISON: soft offlining for non-lru
> movable page" with CONFIG_MIGRATION disabled.
> 
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> ---
>  include/linux/migrate.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/migrate.h b/include/linux/migrate.h
> index ae8d475..631a8c8 100644
> --- a/include/linux/migrate.h
> +++ b/include/linux/migrate.h
> @@ -56,6 +56,8 @@ static inline int migrate_pages(struct list_head *l, new_page_t new,
>  		free_page_t free, unsigned long private, enum migrate_mode mode,
>  		int reason)
>  	{ return -ENOSYS; }
> +static inline bool isolate_movable_page(struct page *page, isolate_mode_t mode)
> +	{ return false; }
>  
>  static inline int migrate_prep(void) { return -ENOSYS; }
>  static inline int migrate_prep_local(void) { return -ENOSYS; }
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm/migration: make isolate_movable_page always defined Yisheng Xie <xieyisheng1@huawei.com> - 2017-01-25 11:50 +0100
  Re: [PATCH] mm/migration: make isolate_movable_page always defined Yisheng Xie <xieyisheng1@huawei.com> - 2017-01-25 12:00 +0100
  Re: [PATCH] mm/migration: make isolate_movable_page always defined Michal Hocko <mhocko@kernel.org> - 2017-01-25 13:10 +0100
    Re: [PATCH] mm/migration: make isolate_movable_page always defined Yisheng Xie <ysxie@foxmail.com> - 2017-01-25 14:30 +0100
  Re: [PATCH] mm/migration: make isolate_movable_page always defined Minchan Kim <minchan@kernel.org> - 2017-01-26 00:50 +0100

csiph-web