Re: [PATCH] mm/migration: make isolate_movable_page always defined

Path	csiph.com!news.redatomik.org!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Yisheng Xie <xieyisheng1@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/migration: make isolate_movable_page always defined
Date	Wed, 25 Jan 2017 12:00:01 +0100
Message-ID	<t3tsZ-GS-7@gated-at.bofh.it> (permalink)
References	<t3tjk-Dr-17@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"
Content-Transfer-Encoding	7bit
X-Originating-IP	[10.177.29.40]
X-Cfilter-Loop	Reflected
X-Mirapoint-Virus-Rapid-Raw	score=unknown(0), refid=str=0001.0A090204.588882F4.0097,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID	847e4bdd0f792357bc7b6a7e9937a743
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	<n-horiguchi@ah.jp.nec.com>, <mhocko@suse.com>, <akpm@linux-foundation.org>, <minchan@kernel.org>, <vbabka@suse.cz>, <guohanjun@huawei.com>, <qiuxishi@huawei.com>
X-Original-Date	Wed, 25 Jan 2017 18:50:03 +0800
X-Original-Message-ID	<6ac6ec39-08d4-e8eb-4528-72e14a8cc0e7@huawei.com>
X-Original-References	<1485340563-60785-1-git-send-email-xieyisheng1@huawei.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1566482

Show key headers only | View raw

Hi Andrew, Minchan, and all:
My former patch "HWPOISON: soft offlining for non-lru
movable page" will cause compiled error when disable
CONFIG_MIGRATION. And this is a patch to fixe it by
define isolate_movable_page as a static inline
function with !CONFIG_MIGRATION.

Could you please help to review it ? Thanks so much~

I am so sorry about that.

Thanks.
Yisheng Xie

On 2017/1/25 18:36, Yisheng Xie wrote:
> Define isolate_movable_page as a static inline function when
> CONFIG_MIGRATION is not enable. It should return false
> here which means failed to isolate movable pages.
> 
> This patch do not have any functional change but to resolve compile
> error caused by former commit "HWPOISON: soft offlining for non-lru
> movable page" with CONFIG_MIGRATION disabled.
> 
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> ---
>  include/linux/migrate.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/migrate.h b/include/linux/migrate.h
> index ae8d475..631a8c8 100644
> --- a/include/linux/migrate.h
> +++ b/include/linux/migrate.h
> @@ -56,6 +56,8 @@ static inline int migrate_pages(struct list_head *l, new_page_t new,
>  		free_page_t free, unsigned long private, enum migrate_mode mode,
>  		int reason)
>  	{ return -ENOSYS; }
> +static inline bool isolate_movable_page(struct page *page, isolate_mode_t mode)
> +	{ return false; }
>  
>  static inline int migrate_prep(void) { return -ENOSYS; }
>  static inline int migrate_prep_local(void) { return -ENOSYS; }
>

Thread

[PATCH] mm/migration: make isolate_movable_page always defined Yisheng Xie <xieyisheng1@huawei.com> - 2017-01-25 11:50 +0100
  Re: [PATCH] mm/migration: make isolate_movable_page always defined Yisheng Xie <xieyisheng1@huawei.com> - 2017-01-25 12:00 +0100
  Re: [PATCH] mm/migration: make isolate_movable_page always defined Michal Hocko <mhocko@kernel.org> - 2017-01-25 13:10 +0100
    Re: [PATCH] mm/migration: make isolate_movable_page always defined Yisheng Xie <ysxie@foxmail.com> - 2017-01-25 14:30 +0100
  Re: [PATCH] mm/migration: make isolate_movable_page always defined Minchan Kim <minchan@kernel.org> - 2017-01-26 00:50 +0100

csiph-web