Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1566352
| From | "Hillf Danton" <hillf.zj@alibaba-inc.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/3] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically |
| Date | 2017-01-25 08:10 +0100 |
| Message-ID | <t3pSp-76h-3@gated-at.bofh.it> (permalink) |
| References | <sQsXL-6e4-17@gated-at.bofh.it> <sQsXL-6e4-25@gated-at.bofh.it> <t1CTM-4W3-17@gated-at.bofh.it> <t38HT-4mc-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tuesday, January 24, 2017 8:41 PM Michal Hocko wrote:
> On Fri 20-01-17 16:33:36, Hillf Danton wrote:
> >
> > On Tuesday, December 20, 2016 9:49 PM Michal Hocko wrote:
> > >
> > > @@ -1013,7 +1013,7 @@ bool out_of_memory(struct oom_control *oc)
> > > * make sure exclude 0 mask - all other users should have at least
> > > * ___GFP_DIRECT_RECLAIM to get here.
> > > */
> > > - if (oc->gfp_mask && !(oc->gfp_mask & (__GFP_FS|__GFP_NOFAIL)))
> > > + if (oc->gfp_mask && !(oc->gfp_mask & __GFP_FS))
> > > return true;
> > >
> > As to GFP_NOFS|__GFP_NOFAIL request, can we check gfp mask
> > one bit after another?
> >
> > if (oc->gfp_mask) {
> > if (!(oc->gfp_mask & __GFP_FS))
> > return false;
> >
> > /* No service for request that can handle fail result itself */
> > if (!(oc->gfp_mask & __GFP_NOFAIL))
> > return false;
> > }
>
> I really do not understand this request.
It's a request of both NOFS and NOFAIL, and I think we can keep it from
hitting oom killer by shuffling the current gfp checks.
I hope it can make nit sense to your work.
> This patch is removing the __GFP_NOFAIL part...
Yes, and I don't stick to handling NOFAIL requests inside oom.
> Besides that why should they return false?
It's feedback to page allocator that no kill is issued, and
extra attention is needed.
thanks
Hillf
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 2/3] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-01-20 09:40 +0100
Re: [PATCH 2/3] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically Michal Hocko <mhocko@kernel.org> - 2017-01-24 13:50 +0100
Re: [PATCH 2/3] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-01-25 08:10 +0100
Re: [PATCH 2/3] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically Michal Hocko <mhocko@kernel.org> - 2017-01-25 09:10 +0100
Re: [PATCH 2/3] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-01-25 09:50 +0100
Re: [PATCH 2/3] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically Michal Hocko <mhocko@kernel.org> - 2017-01-25 11:30 +0100
csiph-web