Re: [PATCH 2/3] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	"Hillf Danton" <hillf.zj@alibaba-inc.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically
Date	Wed, 25 Jan 2017 08:10:02 +0100
Message-ID	<t3pSp-76h-3@gated-at.bofh.it> (permalink)
References	<sQsXL-6e4-17@gated-at.bofh.it> <sQsXL-6e4-25@gated-at.bofh.it> <t1CTM-4W3-17@gated-at.bofh.it> <t38HT-4mc-11@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=alibaba-inc.com; s=default; t=1485327660; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; bh=caQBxiPi/24fDdn3Nod2eXNy9aO+iEn/yF1mRQcQUUA=; b=WDVXjJiOvMOvK5qwyt2aC7f+lLKAA5qhOeG86QHbo1lSRieYttx8L854GGCwcaBSU1waolU8i4/+99OSq/nw+oFof28esI4a0NcIYKdiPRNjyg0hoJAqFyXC5NGK2byM5xFF/d07LemFb4V3Njkfz2Jx6eMR4kgFNRqaon7e2Rs=
X-Alimail-Antispam	AC=PASS;BC=-1\|-1;BR=01201311R201e4;FP=0\|-1\|-1\|-1\|0\|-1\|-1\|-1;HT=e02c03278;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---.7W1HKdI_1485327651;
Reply-To	"Hillf Danton" <hillf.zj@alibaba-inc.com>
MIME-Version	1.0
Content-Type	text/plain; charset="us-ascii"
Content-Transfer-Encoding	7bit
X-Mailer	Microsoft Outlook 14.0
Thread-Index	AQI5GhCbBXj+0AWvuNrZg+/tQ4jXjAKoT3afAkvunb0BwIhoHKBFzqtw
Content-Language	zh-cn
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	"'Andrew Morton'" <akpm@linux-foundation.org>, "'Johannes Weiner'" <hannes@cmpxchg.org>, "'Tetsuo Handa'" <penguin-kernel@I-love.SAKURA.ne.jp>, "'David Rientjes'" <rientjes@google.com>, "'Mel Gorman'" <mgorman@suse.de>, <linux-mm@kvack.org>, "'LKML'" <linux-kernel@vger.kernel.org>
X-Original-Date	Wed, 25 Jan 2017 15:00:51 +0800
X-Original-Message-ID	<003a01d276d8$c41e0180$4c5a0480$@alibaba-inc.com>
X-Original-References	<20161220134904.21023-1-mhocko@kernel.org> <20161220134904.21023-3-mhocko@kernel.org> <001f01d272f7$e53acbd0$afb06370$@alibaba-inc.com> <20170124124048.GE6867@dhcp22.suse.cz>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1566352

Show key headers only | View raw

On Tuesday, January 24, 2017 8:41 PM Michal Hocko wrote: 
> On Fri 20-01-17 16:33:36, Hillf Danton wrote:
> >
> > On Tuesday, December 20, 2016 9:49 PM Michal Hocko wrote:
> > >
> > > @@ -1013,7 +1013,7 @@ bool out_of_memory(struct oom_control *oc)
> > >  	 * make sure exclude 0 mask - all other users should have at least
> > >  	 * ___GFP_DIRECT_RECLAIM to get here.
> > >  	 */
> > > -	if (oc->gfp_mask && !(oc->gfp_mask & (__GFP_FS|__GFP_NOFAIL)))
> > > +	if (oc->gfp_mask && !(oc->gfp_mask & __GFP_FS))
> > >  		return true;
> > >
> > As to GFP_NOFS|__GFP_NOFAIL request, can we check gfp mask
> > one bit after another?
> >
> > 	if (oc->gfp_mask) {
> > 		if (!(oc->gfp_mask & __GFP_FS))
> > 			return false;
> >
> > 		/* No service for request that can handle fail result itself */
> > 		if (!(oc->gfp_mask & __GFP_NOFAIL))
> > 			return false;
> > 	}
> 
> I really do not understand this request. 

It's a request of both NOFS and NOFAIL, and I think we can keep it from
hitting oom killer by shuffling the current gfp checks.
I hope it can make nit sense to your work.

> This patch is removing the __GFP_NOFAIL part... 

Yes, and I don't stick to handling NOFAIL requests inside oom.
 
> Besides that why should they return false?

It's feedback to page allocator that no kill is issued, and 
extra attention is needed.

thanks
Hillf

Thread

Re: [PATCH 2/3] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-01-20 09:40 +0100
  Re: [PATCH 2/3] mm, oom: do not enfore OOM killer for __GFP_NOFAIL  automatically Michal Hocko <mhocko@kernel.org> - 2017-01-24 13:50 +0100
    Re: [PATCH 2/3] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-01-25 08:10 +0100
      Re: [PATCH 2/3] mm, oom: do not enfore OOM killer for __GFP_NOFAIL  automatically Michal Hocko <mhocko@kernel.org> - 2017-01-25 09:10 +0100
        Re: [PATCH 2/3] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-01-25 09:50 +0100
          Re: [PATCH 2/3] mm, oom: do not enfore OOM killer for __GFP_NOFAIL  automatically Michal Hocko <mhocko@kernel.org> - 2017-01-25 11:30 +0100

csiph-web