Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1567318

Re: [PATCH] mm, page_alloc: Use static global work_struct for draining per-cpu pages

Show all headers | View raw

On Wed, Jan 25, 2017 at 04:08:02PM -0800, Andrew Morton wrote:
> > +	for_each_cpu(cpu, &cpus_with_pcps) {
> > +		struct work_struct *work = per_cpu_ptr(&pcpu_drain, cpu);
> > +		INIT_WORK(work, drain_local_pages_wq);
> 
> It's strange to repeatedly run INIT_WORK() in this fashion. 
> Overwriting an atomic_t which should already be zero, initializing a
> list_head which should already be in the initialized state...
> 
> Can we instead do this a single time in init code?
> 

INIT_WORK does different things depending on whether LOCKDEP is enabled or
not and also whether object debugging is enabled. I'd worry that it's not
functionally equivalent or some future change would break the assumptions
about what INIT_WORK does internally. The init cost is there, but it's
insignicant in comparison to the whole workqueue operation or the old
cost of sending IPIs for that matter.

-- 
Mel Gorman
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm, page_alloc: Use static global work_struct for draining  per-cpu pages Mel Gorman <mgorman@techsingularity.net> - 2017-01-25 09:40 +0100
  Re: [PATCH] mm, page_alloc: Use static global work_struct for  draining per-cpu pages Vlastimil Babka <vbabka@suse.cz> - 2017-01-25 10:30 +0100
  Re: [PATCH] mm, page_alloc: Use static global work_struct for draining per-cpu pages "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-01-25 10:40 +0100
  Re: [PATCH] mm, page_alloc: Use static global work_struct for  draining per-cpu pages Andrew Morton <akpm@linux-foundation.org> - 2017-01-26 01:10 +0100
    Re: [PATCH] mm, page_alloc: Use static global work_struct for  draining per-cpu pages Mel Gorman <mgorman@techsingularity.net> - 2017-01-26 11:50 +0100
      Re: [PATCH] mm, page_alloc: Use static global work_struct for  draining per-cpu pages Tejun Heo <tj@kernel.org> - 2017-01-26 20:30 +0100

csiph-web