Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1565796

Re: [PATCH] cxl: drop unused header asm/pnv-pci.h

Show all headers | View raw

On Tue, 24 Jan 2017 20:57:06 +1100
Michael Ellerman <mpe@ellerman.id.au> wrote:

> Greg Kurz <groug@kaod.org> writes:
> 
> > The kernel API does not use anything from this header file.  
> 
> That's actually hard to prove in general, because pnv-pci.h includes
> linux/pci.h, linux/pci_hotplug.h, linux/irq.h, misc/cxl-base.h and
> asm/opal-api.h. At least four of which aren't included directly by
> api.c.
> 
> But I'll take you word for it :)
> 

Sorry for the lack of details...

api.c doesn't do anything related to pci hotplug, nor to OPAL. This
happens in pci.c.

It includes cxl.h which includes misc/cxl-base.h.

The only generic irq bits are irq_hw_number_t, provided by linux/types.h,
and irq_find_mapping(), provided by linux/irqdomain.h, which is included
by misc/cxl-base.h -> linux/interrupt.h -> asm/irq.h.

Cheers (and congrats :)

--
Greg


> cheers
> 
> > diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
> > index 1b35e33d2434..bcc030eacab7 100644
> > --- a/drivers/misc/cxl/api.c
> > +++ b/drivers/misc/cxl/api.c
> > @@ -11,7 +11,6 @@
> >  #include <linux/slab.h>
> >  #include <linux/file.h>
> >  #include <misc/cxl.h>
> > -#include <asm/pnv-pci.h>
> >  #include <linux/msi.h>
> >  #include <linux/module.h>
> >  #include <linux/mount.h>  

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] cxl: drop unused header asm/pnv-pci.h Greg Kurz <groug@kaod.org> - 2017-01-19 12:00 +0100
  Re: [PATCH] cxl: drop unused header asm/pnv-pci.h Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2017-01-19 15:30 +0100
  Re: [PATCH] cxl: drop unused header asm/pnv-pci.h Frederic Barrat <fbarrat@linux.vnet.ibm.com> - 2017-01-21 19:50 +0100
  Re: [PATCH] cxl: drop unused header asm/pnv-pci.h Michael Ellerman <mpe@ellerman.id.au> - 2017-01-24 11:00 +0100
    Re: [PATCH] cxl: drop unused header asm/pnv-pci.h Greg Kurz <groug@kaod.org> - 2017-01-24 12:50 +0100
    Re: [PATCH] cxl: drop unused header asm/pnv-pci.h Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2017-01-25 00:30 +0100
  Re: cxl: drop unused header asm/pnv-pci.h Michael Ellerman <patch-notifications@ellerman.id.au> - 2017-01-27 01:50 +0100

csiph-web