Re: [PATCH] cxl: drop unused header asm/pnv-pci.h

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Greg Kurz <groug@kaod.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cxl: drop unused header asm/pnv-pci.h
Date	Tue, 24 Jan 2017 12:50:01 +0100
Message-ID	<t37LP-3LP-13@gated-at.bofh.it> (permalink)
References	<t1iBH-uk-1@gated-at.bofh.it> <t363t-2EC-11@gated-at.bofh.it>
X-Original-To	Michael Ellerman <mpe@ellerman.id.au>
X-Mailer	Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
X-Ovh-Tracer-ID	4538221050978605489
X-Vr-Spamstate	OK
X-Vr-Spamscore	-100
X-Vr-Spamcause	gggruggvucftvghtrhhoucdtuddrfeelgedrhedugdeffecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	46
Organization	linux.* mail to news gateway
X-Original-Cc	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Frederic Barrat <fbarrat@linux.vnet.ibm.com>, Ian Munsie <imunsie@au1.ibm.com>
X-Original-Date	Tue, 24 Jan 2017 12:48:05 +0100
X-Original-Message-ID	<20170124124805.6b8e798f@bahia.lan>
X-Original-References	<148482301037.30441.14177888563610790803.stgit@bahia> <87k29kaih9.fsf@concordia.ellerman.id.au>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1565796

Show key headers only | View raw

On Tue, 24 Jan 2017 20:57:06 +1100
Michael Ellerman <mpe@ellerman.id.au> wrote:

> Greg Kurz <groug@kaod.org> writes:
> 
> > The kernel API does not use anything from this header file.  
> 
> That's actually hard to prove in general, because pnv-pci.h includes
> linux/pci.h, linux/pci_hotplug.h, linux/irq.h, misc/cxl-base.h and
> asm/opal-api.h. At least four of which aren't included directly by
> api.c.
> 
> But I'll take you word for it :)
> 

Sorry for the lack of details...

api.c doesn't do anything related to pci hotplug, nor to OPAL. This
happens in pci.c.

It includes cxl.h which includes misc/cxl-base.h.

The only generic irq bits are irq_hw_number_t, provided by linux/types.h,
and irq_find_mapping(), provided by linux/irqdomain.h, which is included
by misc/cxl-base.h -> linux/interrupt.h -> asm/irq.h.

Cheers (and congrats :)

--
Greg


> cheers
> 
> > diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
> > index 1b35e33d2434..bcc030eacab7 100644
> > --- a/drivers/misc/cxl/api.c
> > +++ b/drivers/misc/cxl/api.c
> > @@ -11,7 +11,6 @@
> >  #include <linux/slab.h>
> >  #include <linux/file.h>
> >  #include <misc/cxl.h>
> > -#include <asm/pnv-pci.h>
> >  #include <linux/msi.h>
> >  #include <linux/module.h>
> >  #include <linux/mount.h>

Thread

[PATCH] cxl: drop unused header asm/pnv-pci.h Greg Kurz <groug@kaod.org> - 2017-01-19 12:00 +0100
  Re: [PATCH] cxl: drop unused header asm/pnv-pci.h Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2017-01-19 15:30 +0100
  Re: [PATCH] cxl: drop unused header asm/pnv-pci.h Frederic Barrat <fbarrat@linux.vnet.ibm.com> - 2017-01-21 19:50 +0100
  Re: [PATCH] cxl: drop unused header asm/pnv-pci.h Michael Ellerman <mpe@ellerman.id.au> - 2017-01-24 11:00 +0100
    Re: [PATCH] cxl: drop unused header asm/pnv-pci.h Greg Kurz <groug@kaod.org> - 2017-01-24 12:50 +0100
    Re: [PATCH] cxl: drop unused header asm/pnv-pci.h Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2017-01-25 00:30 +0100
  Re: cxl: drop unused header asm/pnv-pci.h Michael Ellerman <patch-notifications@ellerman.id.au> - 2017-01-27 01:50 +0100

csiph-web