Re: [PATCH 1/2] dt-bindings: add Asus Tinker board

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] dt-bindings: add Asus Tinker board
Date	2017-01-21 21:50 +0100
Message-ID	<t2aLL-8sX-5@gated-at.bofh.it> (permalink)
References	<t1auu-3KN-5@gated-at.bofh.it> <t1auu-3KN-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 19, 2017 at 10:11:58AM +0800, Eddie Cai wrote:
> Tinker board is a credit card size develop board designed by Asus.
> Powered by RK3288.
> 
> Signed-off-by: Eddie Cai <eddie.cai@rock-chips.com>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt b/Documentation/devicetree/bindings/arm/rockchip.txt
> index cc4ace6..ce1f04a 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.txt
> +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
> @@ -1,5 +1,8 @@
>  Rockchip platforms device tree bindings
>  ---------------------------------------
> +- Asus Tinker board
> +    Required root node properties:
> +      - compatible = "rockchip,rk3288-tinker", "rockchip,rk3288";

This should be asus,tinker if that's specific enough. At least the board 
manufacturer should be the vendor.

>  
>  - Kylin RK3036 board:
>      Required root node properties:
> -- 
> 2.7.4
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Add support for RK3288 Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-01-19 03:20 +0100
  [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-01-19 03:20 +0100
    Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Heiko Stuebner <heiko@sntech.de> - 2017-01-19 11:30 +0100
      Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-01-20 08:20 +0100
        Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Heiko Stuebner <heiko@sntech.de> - 2017-01-20 09:20 +0100
          Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-01-20 09:50 +0100
    Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Shawn Lin <shawn.lin@rock-chips.com> - 2017-01-20 03:40 +0100
      Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-01-20 08:20 +0100
        Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Shawn Lin <shawn.lin@rock-chips.com> - 2017-01-20 08:50 +0100
  [PATCH 1/2] dt-bindings: add Asus Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-01-19 03:20 +0100
    Re: [PATCH 1/2] dt-bindings: add Asus Tinker board Rob Herring <robh@kernel.org> - 2017-01-21 21:50 +0100

csiph-web