Re: [PATCH 1/2] dt-bindings: add Asus Tinker board

Path	csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] dt-bindings: add Asus Tinker board
Date	Sat, 21 Jan 2017 21:50:01 +0100
Message-ID	<t2aLL-8sX-5@gated-at.bofh.it> (permalink)
References	<t1auu-3KN-5@gated-at.bofh.it> <t1auu-3KN-7@gated-at.bofh.it>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=C6A2BFWiiZqL23BQaipaSK3v3Fv2/tS86uK3aQtlAOE=; b=LqKmUlO4mY9+e98i4eWgaw1ILtQbHaT8C8mhmQO8UhMlrW1Gu+ttnQwsBx0rIsVC0s kAinFj5nKWW6oaqXx/FJRC4tljsXakXBZG47B5kTXQC6DyVjvk9EAA9MZmen0He/5SJh eE/tfx2z/XhyeTrEm0B3C3d0BA55bzbuTutrBF8KlUzF04ojKTyBxYySqDsMdUt8rs1k PDyUAGR6YzRa9+v0lkObUOnd5usi9oWxhwOUUXLA3Q0O5dRBk5KZ9yXDgvJH3332qSsh xpT8j2oWu3fJCQCqtQDDJhtUMmBz7RkMHjNzzFOrLpsI9VCnW5oDWrtmdypHiV4ltUCx cjpw==
X-Gm-Message-State	AIkVDXLYx3iPiy2TRQm/JfDpfM7izRegCHaTH5e0UlSgwZCrKoxWF86CPmGq2JLlPa7KdA==
X-Received	by 10.202.192.2 with SMTP id q2mr10693281oif.121.1485031339519; Sat, 21 Jan 2017 12:42:19 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.6.2-neo (2016-08-21)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	mark.rutland@arm.com, heiko@sntech.de, linux@armlinux.org.uk, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Eddie Cai <eddie.cai@rock-chips.com>
X-Original-Date	Sat, 21 Jan 2017 14:42:17 -0600
X-Original-Message-ID	<20170121204217.y54lup7wkm7y7iwp@rob-hp-laptop>
X-Original-References	<1484791919-4665-1-git-send-email-eddie.cai@rock-chips.com> <1484791919-4665-2-git-send-email-eddie.cai@rock-chips.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1564240

Show key headers only | View raw

On Thu, Jan 19, 2017 at 10:11:58AM +0800, Eddie Cai wrote:
> Tinker board is a credit card size develop board designed by Asus.
> Powered by RK3288.
> 
> Signed-off-by: Eddie Cai <eddie.cai@rock-chips.com>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt b/Documentation/devicetree/bindings/arm/rockchip.txt
> index cc4ace6..ce1f04a 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.txt
> +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
> @@ -1,5 +1,8 @@
>  Rockchip platforms device tree bindings
>  ---------------------------------------
> +- Asus Tinker board
> +    Required root node properties:
> +      - compatible = "rockchip,rk3288-tinker", "rockchip,rk3288";

This should be asus,tinker if that's specific enough. At least the board 
manufacturer should be the vendor.

>  
>  - Kylin RK3036 board:
>      Required root node properties:
> -- 
> 2.7.4
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Add support for RK3288 Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-01-19 03:20 +0100
  [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-01-19 03:20 +0100
    Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Heiko Stuebner <heiko@sntech.de> - 2017-01-19 11:30 +0100
      Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-01-20 08:20 +0100
        Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Heiko Stuebner <heiko@sntech.de> - 2017-01-20 09:20 +0100
          Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-01-20 09:50 +0100
    Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Shawn Lin <shawn.lin@rock-chips.com> - 2017-01-20 03:40 +0100
      Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-01-20 08:20 +0100
        Re: [PATCH 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Shawn Lin <shawn.lin@rock-chips.com> - 2017-01-20 08:50 +0100
  [PATCH 1/2] dt-bindings: add Asus Tinker board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-01-19 03:20 +0100
    Re: [PATCH 1/2] dt-bindings: add Asus Tinker board Rob Herring <robh@kernel.org> - 2017-01-21 21:50 +0100

csiph-web