Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1563356

Re: [PATCH v3 1/3] mmc: dt-bindings: update Mediatek MMC bindings

Show all headers | View raw

+devicetree, Rob

On 19 January 2017 at 11:19, Yong Mao <yong.mao@mediatek.com> wrote:
> From: yong mao <yong.mao@mediatek.com>
>
> Add description for mtk-hs200-cmd-int-delay
> Add description for mtk-hs400-cmd-int-delay
> Add description for mtk-hs400-cmd-resp-sel
>
> Signed-off-by: Yong Mao <yong.mao@mediatek.com>
> ---
>  Documentation/devicetree/bindings/mmc/mtk-sd.txt |    9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> index 0120c7f..149f472 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> @@ -21,6 +21,12 @@ Optional properties:
>  - assigned-clocks: PLL of the source clock
>  - assigned-clock-parents: parent of source clock, used for HS400 mode to get 400Mhz source clock
>  - hs400-ds-delay: HS400 DS delay setting
> +- mtk-hs200-cmd-int-delay: HS200 command internal delay setting.
> +                          The value is an integer from 0 to 31

Please change to:

mediatek,hs200-cmd-delay

... and if there is a unit, like ns or us, please add that a suffix.

> +- mtk-hs400-cmd-int-delay: HS400 command internal delay setting
> +                          The value is an integer from 0 to 31

mediatek,hs400-cmd-delay and add unit if applicable.

> +- mtk-hs400-cmd-resp-sel:  HS400 command response sample selection
> +                          The value is an integer from 0 to 1

mediatek,hs400-cmd-resp-sel

And make it a boolean value instead!

>
>  Examples:
>  mmc0: mmc@11230000 {
> @@ -38,4 +44,7 @@ mmc0: mmc@11230000 {
>         assigned-clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>;
>         assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL_D2>;
>         hs400-ds-delay = <0x14015>;
> +       mtk-hs200-cmd-int-delay = <26>;
> +       mtk-hs400-cmd-int-delay = <14>;
> +       mtk-hs400-cmd-resp-sel = <0>; /* 0: rising, 1: falling */

The rising/falling information belongs in description of the binding a
few lines above. Please move it there.

>  };
> --
> 1.7.9.5
>

Kind regards
Uffe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/3] mmc: mediatek: Use data tune for CMD line tune  Yong Mao <yong.mao@mediatek.com> - 2017-01-19 11:20 +0100
  [PATCH v3 2/3] dts: mediatek: configure some fixed mmc parameters Yong Mao <yong.mao@mediatek.com> - 2017-01-19 11:20 +0100
    Re: [PATCH v3 2/3] dts: mediatek: configure some fixed mmc parameters Ulf Hansson <ulf.hansson@linaro.org> - 2017-01-20 09:10 +0100
      Re: [PATCH v3 2/3] dts: mediatek: configure some fixed mmc parameters Matthias Brugger <matthias.bgg@gmail.com> - 2017-01-24 11:40 +0100
  [PATCH v3 1/3] mmc: dt-bindings: update Mediatek MMC bindings Yong Mao <yong.mao@mediatek.com> - 2017-01-19 11:30 +0100
    Re: [PATCH v3 1/3] mmc: dt-bindings: update Mediatek MMC bindings Daniel Kurtz <djkurtz@chromium.org> - 2017-01-20 08:50 +0100
    Re: [PATCH v3 1/3] mmc: dt-bindings: update Mediatek MMC bindings Ulf Hansson <ulf.hansson@linaro.org> - 2017-01-20 09:10 +0100
  [PATCH v3 3/3] mmc: mediatek: Use data tune for CMD line tune Yong Mao <yong.mao@mediatek.com> - 2017-01-19 11:30 +0100
    Re: [PATCH v3 3/3] mmc: mediatek: Use data tune for CMD line tune kbuild test robot <lkp@intel.com> - 2017-01-20 05:50 +0100
    [PATCH] mmc: mediatek: fix semicolon.cocci warnings kbuild test robot <lkp@intel.com> - 2017-01-20 06:00 +0100
    Re: [PATCH v3 3/3] mmc: mediatek: Use data tune for CMD line tune Ulf Hansson <ulf.hansson@linaro.org> - 2017-01-20 09:30 +0100

csiph-web