Re: [PATCH RESEND] coredump: Ensure proper size of sparse core files

From	Dave Kleikamp <dave.kleikamp@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND] coredump: Ensure proper size of sparse core files
Date	2017-01-17 22:10 +0100
Message-ID	<t0JaV-3FT-3@gated-at.bofh.it> (permalink)
References	<sYwKR-2sb-9@gated-at.bofh.it> <t0sWt-1EX-7@gated-at.bofh.it> <t0wQp-4ey-1@gated-at.bofh.it> <t0IRz-3jt-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/17/2017 02:44 PM, David Miller wrote:
> From: Christoph Hellwig <hch@infradead.org>
> Date: Mon, 16 Jan 2017 23:55:21 -0800
> 
>> On Mon, Jan 16, 2017 at 10:42:43PM -0500, David Miller wrote:
>>> The lseek() done by dump_skip() should extend the file properly.
>>
>> lseek never extends a file.  It just moves the current file position.
>> So if you do not have a write after the lseek it does nothing.
> 
> Ok, then the only other feedback I have is that we should probably
> defer this truncate() call until the last possible dump write occurs
> rather than right after the VMA loop.

Yeah. That's fine with me.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH RESEND] coredump: Ensure proper size of sparse core  files David Miller <davem@davemloft.net> - 2017-01-17 04:50 +0100
  Re: [PATCH RESEND] coredump: Ensure proper size of sparse core files Christoph Hellwig <hch@infradead.org> - 2017-01-17 09:00 +0100
    Re: [PATCH RESEND] coredump: Ensure proper size of sparse core  files David Miller <davem@davemloft.net> - 2017-01-17 21:50 +0100
      Re: [PATCH RESEND] coredump: Ensure proper size of sparse core files Dave Kleikamp <dave.kleikamp@oracle.com> - 2017-01-17 22:10 +0100

csiph-web