Re: [PATCH RESEND] coredump: Ensure proper size of sparse core files

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Dave Kleikamp <dave.kleikamp@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND] coredump: Ensure proper size of sparse core files
Date	Tue, 17 Jan 2017 22:10:01 +0100
Message-ID	<t0JaV-3FT-3@gated-at.bofh.it> (permalink)
References	<sYwKR-2sb-9@gated-at.bofh.it> <t0sWt-1EX-7@gated-at.bofh.it> <t0wQp-4ey-1@gated-at.bofh.it> <t0IRz-3jt-7@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
X-Source-IP	userv0021.oracle.com [156.151.31.71]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	15
Organization	linux.* mail to news gateway
X-Original-Cc	viro@zeniv.linux.org.uk, sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 17 Jan 2017 15:01:07 -0600
X-Original-Message-ID	<3238f60a-2638-5d9b-4d8d-f9118c90e7b5@oracle.com>
X-Original-References	<32910821-8b16-1107-20de-b34d029b3e9a@oracle.com> <20170116.224243.706466650029722351.davem@davemloft.net> <20170117075521.GA19654@infradead.org> <20170117.154453.1379705071819128189.davem@davemloft.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1561021

Show key headers only | View raw

On 01/17/2017 02:44 PM, David Miller wrote:
> From: Christoph Hellwig <hch@infradead.org>
> Date: Mon, 16 Jan 2017 23:55:21 -0800
> 
>> On Mon, Jan 16, 2017 at 10:42:43PM -0500, David Miller wrote:
>>> The lseek() done by dump_skip() should extend the file properly.
>>
>> lseek never extends a file.  It just moves the current file position.
>> So if you do not have a write after the lseek it does nothing.
> 
> Ok, then the only other feedback I have is that we should probably
> defer this truncate() call until the last possible dump write occurs
> rather than right after the VMA loop.

Yeah. That's fine with me.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH RESEND] coredump: Ensure proper size of sparse core  files David Miller <davem@davemloft.net> - 2017-01-17 04:50 +0100
  Re: [PATCH RESEND] coredump: Ensure proper size of sparse core files Christoph Hellwig <hch@infradead.org> - 2017-01-17 09:00 +0100
    Re: [PATCH RESEND] coredump: Ensure proper size of sparse core  files David Miller <davem@davemloft.net> - 2017-01-17 21:50 +0100
      Re: [PATCH RESEND] coredump: Ensure proper size of sparse core files Dave Kleikamp <dave.kleikamp@oracle.com> - 2017-01-17 22:10 +0100

csiph-web